Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Td/class syntax #21325

Draft
wants to merge 12 commits into
base: trunk
Choose a base branch
from
+2,367 −2,457
Draft

Td/class syntax #21325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
138b0b7
Refactor classes to use newer syntax with `class` keyword
FAMarfuaty Jan 11, 2024
781a62f
use `import` statement instead of `require`
FAMarfuaty Jan 11, 2024
e63d1d7
Refactor the class
FAMarfuaty Jan 15, 2024
386cc38
Explicitly make parse method static. This way this method can only be…
FAMarfuaty Jan 16, 2024
4215e2c
Remove irrelevant tests. Now parse method is a static method of the c…
FAMarfuaty Jan 16, 2024
9d83ec1
refactor AssessorPresenter to use class
FAMarfuaty Jan 16, 2024
0bc4453
Fix the way we access the `parse` method
FAMarfuaty Jan 16, 2024
65616ad
Code scouting fixes
mhkuu Apr 17, 2024
bf0e33d
Uses class syntax for App
mhkuu Apr 18, 2024
8b8e18e
Uses class syntax for assessors (first pass)
mhkuu Apr 18, 2024
995dc7a
Alternative way of providing cornerstone values
mhkuu Apr 24, 2024
ca33693
Merge branch 'trunk' of github.com:Yoast/wordpress-seo into td/class-…
mhkuu May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions packages/yoastseo/spec/languageProcessing/values/ClauseSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,5 @@ describe( "a test for serializing and parsing a Clause class instance", function
isPassive: false,
participles: [],
} );
expect( mockClause.parse( mockClause.serialize() ) ).toEqual( {
_clauseText: "The cat is loved.",
_auxiliaries: [ "is" ],
_isPassive: false,
_participles: [],
} );
} );
} );
10 changes: 0 additions & 10 deletions packages/yoastseo/spec/languageProcessing/values/SentenceSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,15 +64,5 @@ describe( "Creates a sentence object", function() {
isPassive: true,
sentenceText: "Cats are adored.",
} );
expect( sentence.parse( sentence.serialize() ) ).toEqual( {
_clauses: [
{ _auxiliaries: [ "are" ],
_clauseText: "Cats are adored",
_isPassive: true,
_participles: [],
} ],
_isPassive: true,
_sentenceText: "Cats are adored.",
} );
} );
} );
Loading
Loading