Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Td/class syntax #21325

Draft
wants to merge 12 commits into
base: trunk
Choose a base branch
from
Draft

Td/class syntax #21325

wants to merge 12 commits into from
+2,367 −2,457

Commits on Apr 17, 2024

  1. Refactor classes to use newer syntax with class keyword

    @FAMarfuaty @mhkuu
    FAMarfuaty authored and mhkuu committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    138b0b7 View commit details
    Browse the repository at this point in the history

  2. use import statement instead of require

    @FAMarfuaty @mhkuu
    FAMarfuaty authored and mhkuu committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    781a62f View commit details
    Browse the repository at this point in the history

  3. Refactor the class

    @FAMarfuaty @mhkuu
    FAMarfuaty authored and mhkuu committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    e63d1d7 View commit details
    Browse the repository at this point in the history

  4. Explicitly make parse method static. This way this method can only be… 

    … accessed from the Class itself and not from the object instance of the class.
    @FAMarfuaty @mhkuu
    FAMarfuaty authored and mhkuu committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    386cc38 View commit details
    Browse the repository at this point in the history

  5. Remove irrelevant tests. Now parse method is a static method of the c… 

    …lass, which means that it cannot be accessed from an object instance of that class.
    @FAMarfuaty @mhkuu
    FAMarfuaty authored and mhkuu committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    4215e2c View commit details
    Browse the repository at this point in the history

  6. refactor AssessorPresenter to use class

    @FAMarfuaty @mhkuu
    FAMarfuaty authored and mhkuu committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    9d83ec1 View commit details
    Browse the repository at this point in the history

  7. Fix the way we access the parse method

    @FAMarfuaty @mhkuu
    FAMarfuaty authored and mhkuu committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    0bc4453 View commit details
    Browse the repository at this point in the history

  8. Code scouting fixes

    @mhkuu
    mhkuu committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    65616ad View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Uses class syntax for App

    @mhkuu
    mhkuu committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    bf0e33d View commit details
    Browse the repository at this point in the history

  2. Uses class syntax for assessors (first pass)

    @mhkuu
    mhkuu committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    8b8e18e View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. Alternative way of providing cornerstone values

    @mhkuu
    mhkuu committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    995dc7a View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Merge branch 'trunk' of github.com:Yoast/wordpress-seo into td/class-… 

    …syntax
    @mhkuu
    mhkuu committed May 13, 2024
    Configuration menu
    Copy the full SHA
    ca33693 View commit details
    Browse the repository at this point in the history