Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring several small improvements to WordPress RSS feeds #18555

Merged
merged 2 commits into from
Jun 20, 2022

Conversation

jdevalk
Copy link
Contributor

@jdevalk jdevalk commented Jun 12, 2022

Context

  • Brings some of the RSS feed enhancements we've long done on yoast.com to Yoast SEO.

Summary

This PR can be summarized in the following changelog entry:

  • Adds canonical HTTP headers from RSS feeds to their parent URLs (for instance your homepage, or specific categories or tags), so the feeds themselves don't show up in search results.
  • Makes sure the title separator chosen in Yoast SEO is used for RSS feed titles too.
  • Makes sure the link tag in the RSS feeds' channel section links to the most specific URL possible (for instance the category or tag the RSS feed is for) instead of the homepage.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

When testing this on yoast.com, be sure to delete site/core-yoastcom/WordPress/Integration/YoastSEO/Feeds.php first.

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended
  • I have written this PR in accordance with my team's definition of done.

Fixes PRODUCT-179

@jdevalk jdevalk added the changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog label Jun 12, 2022
@enricobattocchi
Copy link
Member

CR & test OK!

@enricobattocchi enricobattocchi merged commit 49e6530 into trunk Jun 20, 2022
@enricobattocchi enricobattocchi deleted the jdv/product-179 branch June 20, 2022 14:59
@IreneStr IreneStr added this to the 19.3 milestone Jun 24, 2022
herregroen pushed a commit that referenced this pull request Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: enhancement Needs to be included in the 'Enhancements' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants