Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty link tag in RSS feed when 'Discourage search engines from indexing site' is enabled #20451

Open
2 tasks done
amboutwe opened this issue Jun 23, 2023 · 3 comments
Open
2 tasks done

Comments

@amboutwe
Copy link
Member

  • I've read and understood the contribution guidelines.
  • I've searched for any related issues and avoided creating a duplicate issue.

Please give us a description of what happened

The link tag for the homepage RSS feed is empty when the entire site is noindexed. This causes the feed to be invalid, meaning that any customization or integration with the RSS feed cannot be validated in a staging/development site before pushing to a production environment.

Regression related to this PR. The issue does not happen with 19.2 but does happen in 19.3, 20.8, and 20.9 versions.

Workaround

The warnings can be ignored if they are the only lines that cause the feed not to validate, as they would not occur when the site is visible to search engines.

To Reproduce

Step-by-step reproduction instructions

Starting with a vanilla installation:

  1. Go to Admin > Settings > Reading
  2. Check 'Discourage search engines from indexing site'
  3. Go to feed (example.com/feed/)
  4. See the valid link tag of <link>https://example.com</link>
  5. Install and activate Yoast SEO (free)
  6. Go to feed (example.com/feed/)
  7. See the empty link tag of <link></link>

Expected results

  1. Link tag would be valid despite discouraging search engines

Actual results

  1. Empty link tag when search engines are discouraged from indexing the site

Screenshots, screen recording, code snippet

Without Yoast (same when using v19.2)
shown_without_yoast

With Yoast 20.9 (same when using v19.3)
empty_with_yoast

Technical info

Used versions

  • Device you are using: N/A
  • Operating system: N/A
  • PHP version: N/A
  • WordPress version: 6.2.2
  • WordPress Theme: Twenty Twenty-Three v1.1
  • Yoast SEO version: 20.9 (also happens with 20.8 and 19.3 but not in 19.2)
  • Relevant plugins in case of a bug: N/A
@amboutwe
Copy link
Member Author

Please inform the customer of conversation # 1030076 when this conversation has been closed.

@jeroenrotty jeroenrotty added the IM label Jun 27, 2023
@VictoriaMcCarter
Copy link

Please inform the customer of conversation # 1093466 when this conversation has been closed.

@shabnam611
Copy link

Please inform the customer of conversation # 1116628 when this conversation has been closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants