-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix react key error with position controls #47367
Conversation
Move the key to the array of elements
Size Change: -4 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix @talldan, sorry for missing this one! 🚀
Flaky tests detected in 6859033. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3992512363
|
What?
Fixes a react
![Screen Shot 2023-01-24 at 10 36 59 am](https://user-images.githubusercontent.com/677833/214201253-724413c9-caa4-45ea-9c7f-5460787a4a6a.png)
key
warning that occurs intrunk
:How?
The key should be defined on an element within an array. It looks like it was accidentally refactored out of the array in #47334
Testing Instructions