Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky Test] should handle Enter across blocks #39763

Closed
github-actions bot opened this issue Mar 25, 2022 · 1 comment · Fixed by #48035
Closed

[Flaky Test] should handle Enter across blocks #39763

github-actions bot opened this issue Mar 25, 2022 · 1 comment · Fixed by #48035
Labels
[Type] Flaky Test Auto-generated flaky test report issue

Comments

@github-actions
Copy link

github-actions bot commented Mar 25, 2022

Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.

Test title

should handle Enter across blocks

Test path

/test/e2e/specs/editor/various/multi-block-selection.spec.js

Errors

[2022-03-29T13:42:56.215Z] Test passed after 1 failed attempt on fix/use-entity-records-eslint-warning.
[2022-07-20T10:31:19.262Z] Test passed after 1 failed attempt on fix/patterns-controller-fatal-error.
[2022-09-21T13:49:14.146Z] Test passed after 1 failed attempt on update/avoid-constinuous-action-calls.
[2022-12-16T14:35:07.473Z] Test passed after 1 failed attempt on try/iframe-block-based-theme-post-editor.
[2022-12-16T15:56:52.773Z] Test passed after 1 failed attempt on update/docgen-list-types.
[2022-12-16T17:53:09.469Z] Test passed after 1 failed attempt on fix/always-init-request-utils.
[2022-12-16T21:36:01.675Z] Test passed after 1 failed attempt on fix/fallback-on-default-layout.
[2022-12-20T11:16:28.944Z] Test passed after 1 failed attempt on add/gutenberg-test-suite-loader.
[2022-12-22T09:28:34.187Z] Test passed after 1 failed attempt on update/site-editor-edit-button.
[2023-01-02T19:04:47.218Z] Test passed after 1 failed attempt on trunk.
[2023-01-03T23:56:55.343Z] Test passed after 1 failed attempt on fix/dropdown-redundant-position-prop.
[2023-01-09T10:38:33.124Z] Test passed after 1 failed attempt on try/pattern-directory-explorer.
[2023-01-10T05:04:32.413Z] Test passed after 1 failed attempt on add/text-only-mode-to-inspector-tabs.
[2023-01-11T18:21:20.852Z] Test passed after 1 failed attempt on trunk.
[2023-01-12T13:05:05.623Z] Test passed after 1 failed attempt on try/announce-when-block-inserted-nav-list-view.
[2023-01-13T08:02:33.343Z] Test passed after 1 failed attempt on add/playwright-tests-codeowner.
[2023-01-13T17:56:47.992Z] Test passed after 1 failed attempt on add/playwright-tests-codeowner.
[2023-01-16T12:29:02.751Z] Test passed after 1 failed attempt on stabilize/__experimentalGetPatternsByBlockTypes.
[2023-01-17T07:29:12.750Z] Test passed after 1 failed attempt on shadow-template-support.
[2023-01-21T07:28:51.002Z] Test passed after 1 failed attempt on add/gallery-caption-toolbar-item.
[2023-01-24T03:16:13.997Z] Test passed after 1 failed attempt on fix/position-controls-react-key-error.
[2023-01-24T14:58:54.295Z] Test passed after 1 failed attempt on shadow-presets.
[2023-01-25T09:59:52.764Z] Test passed after 1 failed attempt on update/sync-editor-settings.
[2023-01-27T00:53:42.554Z] Test passed after 1 failed attempt on update/omit-advanced-panel-only-tabs.
[2023-01-27T13:37:38.551Z] Test passed after 1 failed attempt on enable/react-18-concurrent-mode.
[2023-01-27T14:11:49.063Z] Test passed after 1 failed attempt on enable/react-18-concurrent-mode.
[2023-01-27T19:17:32.309Z] Test passed after 1 failed attempt on update/query-block-setup-state.
[2023-01-28T15:32:49.669Z] Test passed after 1 failed attempt on fix/colorpalette-contrast-check.
[2023-01-30T10:01:14.617Z] Test passed after 1 failed attempt on add/tag-selection-dropdown.
[2023-01-30T14:23:47.130Z] Test passed after 1 failed attempt on trunk.
[2023-01-31T11:28:49.059Z] Test passed after 1 failed attempt on update/extracted-get-supported-styles.
[2023-01-31T16:24:54.599Z] Test passed after 1 failed attempt on trunk.
[2023-02-01T10:24:13.182Z] Test passed after 1 failed attempt on trunk.
[2023-02-01T13:20:07.227Z] Test passed after 1 failed attempt on trunk.
[2023-02-01T13:29:15.526Z] Test passed after 1 failed attempt on update/rename-align-attribute.
[2023-02-01T15:39:24.713Z] Test passed after 1 failed attempt on rnmobile/add-spacer-presets-support.
[2023-02-01T15:59:52.820Z] Test passed after 1 failed attempt on trunk.
[2023-02-01T16:34:28.834Z] Test passed after 1 failed attempt on rnmobile/update-reanimated-2.9.1-wp-3.
[2023-02-02T00:54:37.385Z] Test passed after 1 failed attempt on fix/pattern-explorer-regression.
[2023-02-02T06:25:43.217Z] Test passed after 1 failed attempt on fix/block-json-schema-blockgap.
[2023-02-02T07:41:22.596Z] Test passed after 1 failed attempt on trunk.
[2023-02-02T10:06:42.447Z] Test passed after 1 failed attempt on add/block-types-prop-pattern-directory-controller.
[2023-02-02T10:07:38.473Z] Test passed after 1 failed attempt on fix/47022.
[2023-02-02T11:21:37.266Z] Test passed after 1 failed attempt on fix/focus-on-mount-tabbables-added-later.
[2023-02-02T12:05:47.024Z] Test passed after 1 failed attempt on trunk.
[2023-02-02T13:47:14.134Z] Test passed after 1 failed attempt on fix/query-loop-taxonomy-controls-null-terms.
[2023-02-02T13:55:40.046Z] Test passed after 1 failed attempt on trunk.
[2023-02-02T16:30:26.204Z] Test passed after 1 failed attempt on trunk.
[2023-02-03T02:03:10.891Z] Test passed after 1 failed attempt on add/layout-tests.
[2023-02-03T02:06:36.693Z] Test passed after 1 failed attempt on trunk.
[2023-02-03T03:24:57.504Z] Test passed after 1 failed attempt on update/privatise-__experimentalShowSelectedHint.
[2023-02-03T08:42:01.252Z] Test passed after 1 failed attempt on update/extracted-get-supported-styles.
[2023-02-03T09:59:33.532Z] Test passed after 1 failed attempt on rnmobile/add-visual-tests.
[2023-02-03T10:01:08.742Z] Test passed after 1 failed attempt on try/fix-toolspanel-on-paste-styles.
[2023-02-03T10:41:40.988Z] Test passed after 1 failed attempt on trunk.
[2023-02-03T10:45:41.183Z] Test passed after 1 failed attempt on add/template-revision-button.
[2023-02-03T11:16:39.456Z] Test passed after 1 failed attempt on fix/disallow-drag-drop-into-editor-canvas-from-nav-offcanvas.
[2023-02-03T12:07:24.124Z] Test passed after 1 failed attempt on rnmobile/add-visual-tests-failing-test.
[2023-02-03T13:23:59.497Z] Test passed after 1 failed attempt on update/site-logo-settings-pick.
[2023-02-03T14:03:49.387Z] Test passed after 1 failed attempt on remove/lodash-keycodes.
[2023-02-03T14:06:17.472Z] Test passed after 1 failed attempt on try/block-tools-marry-document-tools.
[2023-02-03T17:36:04.644Z] Test passed after 1 failed attempt on update/extracted-get-supported-styles.
[2023-02-03T17:55:35.566Z] Test passed after 1 failed attempt on update/extracted-get-supported-styles.
[2023-02-03T18:40:47.211Z] Test passed after 1 failed attempt on extract/typography-panel-into-block-editor.
[2023-02-05T13:03:34.967Z] Test passed after 2 failed attempts on update/pattern-categories-order.
[2023-02-05T23:22:08.282Z] Test passed after 1 failed attempt on update/palette-edit-ts.
[2023-02-06T06:31:36.048Z] Test passed after 1 failed attempt on add/button-border-support.
[2023-02-06T06:47:55.785Z] Test passed after 1 failed attempt on fix/disallow-drag-drop-into-editor-canvas-from-nav-offcanvas.
[2023-02-06T12:01:22.891Z] Test passed after 1 failed attempt on refactor/border-box-control-finish-ts-migration.
[2023-02-06T12:05:52.670Z] Test passed after 1 failed attempt on refactor/menu-items-choice-to-typescript.
[2023-02-06T12:14:06.459Z] Test passed after 2 failed attempts on add/nested-template-level.
[2023-02-06T12:57:57.789Z] Test passed after 1 failed attempt on refactor/border-box-control-finish-ts-migration.
[2023-02-06T14:26:57.445Z] Test passed after 1 failed attempt on fix/undo-create-navigation.
[2023-02-06T16:26:47.924Z] Test passed after 1 failed attempt on refator/components-angle-picker-control-typescript.
[2023-02-06T18:10:52.358Z] Test passed after 2 failed attempts on trunk.
[2023-02-06T20:05:24.574Z] Test passed after 1 failed attempt on ts-combobox-control.
[2023-02-06T20:06:20.678Z] Test passed after 1 failed attempt on actions/disable-fail-fast.
[2023-02-06T23:43:32.422Z] Test passed after 1 failed attempt on perf/blast-chrome-flags-in-configs.
[2023-02-07T09:30:05.178Z] Test passed after 1 failed attempt on trunk.
[2023-02-07T09:59:55.930Z] Test passed after 1 failed attempt on trunk.
[2023-02-07T11:19:42.195Z] Test passed after 1 failed attempt on try/nav-block-integration-test-experiment.
[2023-02-07T11:28:08.526Z] Test passed after 2 failed attempts on refactor/lodash-merge-data.
[2023-02-07T14:05:29.891Z] Test passed after 2 failed attempts on trunk.
[2023-02-07T14:55:10.347Z] Test passed after 1 failed attempt on trunk.
[2023-02-07T15:58:28.888Z] Test passed after 1 failed attempt on try/nav-block-integration-test-experiment.
[2023-02-07T18:18:22.727Z] Test passed after 1 failed attempt on fix/append-http-protocol-to-button-links.
[2023-02-08T03:05:32.009Z] Test passed after 1 failed attempt on fix/append-http-protocol-to-button-links.
[2023-02-08T07:57:58.524Z] Test passed after 1 failed attempt on add/tag-selection-dropdown.
[2023-02-08T08:30:09.386Z] Test passed after 1 failed attempt on update/togglecontrol-margin.
[2023-02-08T08:47:40.146Z] Test passed after 1 failed attempt on trunk.
[2023-02-08T10:46:43.412Z] Test passed after 1 failed attempt on e2e-default-classic-menu.
[2023-02-08T14:48:08.045Z] Test passed after 1 failed attempt on rnmobile/new-block-support.
[2023-02-08T15:45:27.602Z] Test passed after 1 failed attempt on e2e-default-only-menu.
[2023-02-08T15:54:01.400Z] Test passed after 1 failed attempt on tests/store-perf-test-results.
[2023-02-08T18:14:20.171Z] Test passed after 1 failed attempt on trunk.
[2023-02-08T18:15:53.775Z] Test passed after 1 failed attempt on update/run-each-performance-test-in-a-separate-page.
[2023-02-08T18:46:53.796Z] Test passed after 1 failed attempt on try/link-preview.
[2023-02-09T00:01:23.374Z] Test passed after 2 failed attempts on tests/run-perf-tests-in-band.
[2023-02-09T07:01:11.613Z] Test passed after 1 failed attempt on try/link-preview.
[2023-02-09T09:01:21.255Z] Test passed after 1 failed attempt on fix/autocomplete-iframe-a11y.
[2023-02-09T09:26:04.171Z] Test passed after 1 failed attempt on refactor/remove-name-element-props-from-typography-panel.
[2023-02-09T10:17:01.812Z] Test passed after 1 failed attempt on fix/vstack-hstack-alignments.
[2023-02-09T10:37:52.864Z] Test passed after 1 failed attempt on trunk.
[2023-02-09T12:31:38.934Z] Test passed after 1 failed attempt on fix/php-unit-tests-46248.
[2023-02-09T15:18:39.694Z] Test passed after 1 failed attempt on add/other-patterns-to-the-template-start-modal.
[2023-02-09T19:01:49.954Z] Test passed after 1 failed attempt on update/make-OffCanvasEditor-use-LeafMoreMenu-by-default.
[2023-02-09T20:11:34.026Z] Test passed after 1 failed attempt on trunk.
[2023-02-10T04:04:26.883Z] Test passed after 1 failed attempt on trunk.
[2023-02-10T04:48:07.436Z] Test passed after 1 failed attempt on add/cover-spacing.
[2023-02-10T09:53:34.111Z] Test passed after 1 failed attempt on trunk.
[2023-02-10T12:24:30.606Z] Test passed after 1 failed attempt on refactor/tools-panel-storybook-typescript.
[2023-02-10T18:40:15.890Z] Test passed after 1 failed attempt on add/query-block-skip-pattern-selector-no-patterns.
[2023-02-11T02:58:04.221Z] Test passed after 1 failed attempt on enhancement/paragraph-top-heading-shortcut.
[2023-02-11T03:43:18.987Z] Test passed after 1 failed attempt on enhancement/paragraph-top-heading-shortcut.
[2023-02-13T00:14:36.224Z] Test passed after 1 failed attempt on fix/get_post_date.
[2023-02-13T08:14:29.001Z] Test passed after 1 failed attempt on refactor/tools-panel-storybook-typescript.
[2023-02-13T09:39:52.039Z] Test passed after 1 failed attempt on trunk.
[2023-02-13T10:09:35.682Z] Test passed after 1 failed attempt on upgrade/playwright.
[2023-02-13T15:23:23.856Z] Test passed after 1 failed attempt on fix/link-ui-list-view-not-closing.
[2023-02-13T23:16:29.659Z] Test passed after 1 failed attempt on update/site-editor-page-title-generation.
[2023-02-13T23:43:00.976Z] Test passed after 1 failed attempt on update/site-editor-page-title-generation.
[2023-02-13T23:44:31.664Z] Test passed after 1 failed attempt on upgrade/playwright.
[2023-02-14T10:06:10.617Z] Test passed after 1 failed attempt on wp/6.2.
[2023-02-14T10:54:47.809Z] Test passed after 1 failed attempt on wp/6.2.
[2023-02-14T11:29:14.607Z] Test passed after 1 failed attempt on update/deps-for-navigation-useeffect.
[2023-02-14T11:48:25.491Z] Test passed after 1 failed attempt on refactor/remove-name-element-props-from-typography-panel.
[2023-02-14T15:01:56.877Z] Test passed after 1 failed attempt on trunk.
[2023-02-14T15:53:12.129Z] Test passed after 1 failed attempt on e2e-fixes-nav-block.
[2023-02-15T02:18:09.589Z] Test passed after 1 failed attempt on trunk.
[2023-02-15T11:37:08.243Z] Test passed after 1 failed attempt on refactor/page-list-modal.
[2023-02-15T13:52:01.422Z] Test passed after 1 failed attempt on update/deps-for-navigation-useeffect.
[2023-02-16T05:44:43.694Z] Test passed after 1 failed attempt on add/contrast-checker-to-root-global-styles-color-screens.
[2023-02-16T15:48:06.355Z] Test passed after 1 failed attempt on add/other-patterns-to-the-template-start-modal.
[2023-02-16T18:17:28.548Z] Test passed after 2 failed attempts on update/freeform-fallback-to-html-block-in-site-editor.
[2023-02-17T10:03:11.193Z] Test passed after 1 failed attempt on fix/selection-on-replace.
[2023-02-17T10:50:25.734Z] Test passed after 1 failed attempt on fix-i18n/block-settings-menu.
[2023-02-17T14:47:16.439Z] Test passed after 1 failed attempt on try/archive-perf-artifacts.
[2023-02-17T14:57:14.627Z] Test passed after 1 failed attempt on fix/firefox-input-rules.
[2023-02-17T15:20:44.334Z] Test passed after 1 failed attempt on update/disable-layout-toolbar-controls-for-content-locked-blocks.
[2023-02-17T15:45:06.914Z] Test passed after 1 failed attempt on fix/Multiple-overwrites-on-rest-controller-class.
[2023-02-17T20:17:02.806Z] Test passed after 1 failed attempt on switch-textarea-autosize-package.
[2023-02-17T21:46:19.064Z] Test passed after 1 failed attempt on try/image-upload-prepublish.
[2023-02-19T10:26:06.516Z] Test passed after 1 failed attempt on try/archive-perf-artifacts.
[2023-02-20T07:56:41.155Z] Test passed after 1 failed attempt on fix-i18n/block-compare.
[2023-02-20T10:56:54.090Z] Test passed after 1 failed attempt on try/remove-mobile-use-async-list.
[2023-02-20T11:15:52.417Z] Test passed after 1 failed attempt on remove/lodash-merge.
[2023-02-20T13:39:26.709Z] Test passed after 1 failed attempt on update/docs-wp-major-release-clarification.
[2023-02-20T16:05:55.953Z] Test passed after 1 failed attempt on trunk.
[2023-02-20T17:26:08.495Z] Test passed after 1 failed attempt on fix/block-remove-focus-management-no-siblings.
[2023-02-20T19:18:06.189Z] Test passed after 1 failed attempt on add/html-tag-processor-wp-6-3-compat-layer.
[2023-02-20T20:23:15.385Z] Test passed after 1 failed attempt on revert/one-page-per-test.
[2023-02-21T05:38:18.014Z] Test passed after 1 failed attempt on add/details-summary-block.
[2023-02-21T05:56:40.238Z] Test passed after 2 failed attempts on fix/playwright-utils-jsdoc.
[2023-02-21T08:08:45.356Z] Test passed after 1 failed attempt on trunk.
[2023-02-21T08:40:33.242Z] Test passed after 2 failed attempts on try/preload-media-categories-empty-check-request.
[2023-02-21T12:28:36.032Z] Test passed after 1 failed attempt on trunk.
[2023-02-21T13:04:19.954Z] Test passed after 1 failed attempt on add/perf-tests-artifacts-upload.
[2023-02-22T06:41:17.787Z] Test passed after 1 failed attempt on trunk.
[2023-02-22T06:58:41.940Z] Test passed after 1 failed attempt on add/layout-aware-margin-styles-for-block-level-global-styles.
[2023-02-22T08:51:10.949Z] Test passed after 1 failed attempt on extract/dimensions-panel.
[2023-02-22T09:54:17.027Z] Test passed after 1 failed attempt on track/lcp-minus-ttfb.
[2023-02-22T13:10:32.480Z] Test passed after 2 failed attempts on trunk.
[2023-02-22T14:06:34.254Z] Test passed after 1 failed attempt on try/use-duotone-presets-for-blocks.
[2023-02-22T16:20:35.629Z] Test passed after 1 failed attempt on trunk.
[2023-02-23T11:29:57.785Z] Test passed after 1 failed attempt on make-allow-reregistration-opt-in-rather-than-opt-outw.
[2023-02-23T16:06:45.074Z] Test passed after 1 failed attempt on update/jest-snapshots.
[2023-02-23T17:33:05.726Z] Test passed after 1 failed attempt on rnmobile/add-spacer-presets-support.
[2023-02-24T08:40:13.115Z] Test passed after 1 failed attempt on fix/widget-importer-empty-state.
[2023-02-24T22:51:50.407Z] Test passed after 1 failed attempt on update/output-duotone-per-block.
[2023-02-28T22:51:07.185Z] Test passed after 1 failed attempt on release/15.2.
[2023-11-07T22:52:27.463Z] Test passed after 1 failed attempt on experiment/show-styles-inherited-values.
[2023-11-14T21:28:02.121Z] Test passed after 1 failed attempt on experiment/show-styles-inherited-values.
Error: expect(received).toMatchObject(expected)

- Expected  - 2
+ Received  + 2

  Array [
    Object {
      "attributes": Object {
-       "content": "1",
+       "content": ".",
      },
      "name": "core/paragraph",
    },
    Object {
      "attributes": Object {
-       "content": "|2",
+       "content": "|]2",
        "level": 2,
      },
      "name": "core/heading",
    },
  ]

Call Log:
- Timeout 5000ms exceeded while waiting on the predicate
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/multi-block-selection.spec.js:1123:3
@github-actions github-actions bot added the [Type] Flaky Test Auto-generated flaky test report issue label Mar 25, 2022
@github-actions
Copy link
Author

This issue has gone 30 days without any activity.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Aug 25, 2022
@github-actions github-actions bot reopened this Sep 21, 2022
@github-actions github-actions bot reopened this Dec 16, 2022
github-actions bot referenced this issue Dec 16, 2022
…lue.

While working on #38923 with invalid blocks it happened that a JavaScript
error surfaced when working with a block that specified an incorrect layout
type. In the case at hand the block asked for the `flerx` alignment instead
of the `flex` alignment.

It's reasonable to expect blocks to call for unrecognized layouts,
especially if a plugin introduces new layouts and then blocks are loaded
without that plugin's support.

When `getLayoutType` is unable to find a recognized layout it returns
`undefined` which causes numerous issues with calling code that expects
a valid layout.

In this patch we're guarding for those cases and if no known layout can
be found for the specified layout type then we return the default layout
instead. This introduces data corruption so it could be that this solution
is more of a coverup than a fix. There is no way however to ignore that
layout and preserve the behavior while still editing the block. On the
other hand a block should not fail validation due to an implementation bug
in the core editor and if this fix truly resolves the issue we should find
invalidated blocks and prevent editing anyway (unfortunately this is not
the case in this patch).
@github-actions github-actions bot removed the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Dec 18, 2022
github-actions bot referenced this issue Dec 20, 2022
Co-authored-by: Dennis Snell <[email protected]>
github-actions bot referenced this issue Feb 22, 2023
* Add @borrows to correctly copy the jsdoc

* Remove all jsdoc types in favor of typescript types
github-actions bot referenced this issue Feb 22, 2023
* feat(link-control): show text only labels

* chore(link-control): change setting button title

* fix(link-control): update tests

* chore(link-control): use editor top level interface css class to add the label text

* fix(link-control): reduce show-icon-labels css specificity

* fix: pass slot in off-canvas-editor and navigation-link
@github-actions github-actions bot reopened this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Flaky Test Auto-generated flaky test report issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant