Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Excerpt: Specify paragraph as post excerpt tag name #37412

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

mikachan
Copy link
Member

Description

This is a small PR to change the tag for the post excerpt in the editor from a div to a p. This is to bring the markup more in line with what is output on the front end, which is a p inside a div, like this:

<div class="wp-block-post-excerpt">
     <p class="wp-block-post-excerpt__excerpt">...

This also fixes potential styling inconsistencies between the editor and the front end with styles that are applied to paragraph tags.

How has this been tested?

I've manually tested this using emptytheme, inserting a post excerpt and then ensuring the element changes to a paragraph in the editor.

Screenshots

Before After
image image

Types of changes

Enhancement

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@carolinan carolinan added [Block] Post Excerpt Affects the Post Excerpt Block [Type] Bug An existing feature does not function as intended labels Dec 20, 2021
@scruffian scruffian merged commit 48e300e into WordPress:trunk Dec 21, 2021
@github-actions github-actions bot added this to the Gutenberg 12.3 milestone Dec 21, 2021
@mikachan mikachan deleted the update/post-excerpt-tag-name branch December 21, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Excerpt Affects the Post Excerpt Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants