Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seedlet: Post excerpt block does not include the correct line height #4208

Closed
kjellr opened this issue Jul 12, 2021 · 5 comments
Closed

Seedlet: Post excerpt block does not include the correct line height #4208

kjellr opened this issue Jul 12, 2021 · 5 comments
Assignees

Comments

@kjellr
Copy link
Contributor

kjellr commented Jul 12, 2021

The post excerpt block has incorrect line height in the editor.

Steps to replicate

  1. Add a "Post Excerpt" block.
  2. Save your post or page, view it on the front end.

Screenshots

Editor Front-end
Screen Shot 2021-07-12 at 10 53 48 AM Screen Shot 2021-07-12 at 10 53 54 AM
@MaggieCabrera
Copy link
Contributor

This is only happening on dotcom. On my local install with the latest GB from trunk and WP 5.8 I see it correctly. There's a missing p tag wrapping the excerpt text.

Dotcom Local
Screenshot 2021-07-21 at 16 08 33 Screenshot 2021-07-21 at 16 04 44

@MaggieCabrera
Copy link
Contributor

MaggieCabrera commented Jul 21, 2021

Looking at the code of the block, I don't see that the p tag is being added at all in the editor, while it is present explicitly on the frontend. I'm going to put this one on hold until dotcom has the latest version of the editor and then go back to this, but if it's still happening, the fix belongs on the editor, not the theme.

@pbking
Copy link
Contributor

pbking commented Dec 13, 2021

Tested this again, it's still happening exclusively on .com. The appropriate elements are rendered using any version of the plugin locally. I haven't been able to determine what about that installation is causing it but again confirming that it's something specific there.

@mikachan
Copy link
Member

I don't know if I'm over-simplifying this, but it seems this could be because the post excerpt isn't rendered as a paragraph in the editor (it's a div instead), whereas on the front end it is. I've opened a GB PR for this: WordPress/gutenberg#37412

@mikachan mikachan self-assigned this Dec 17, 2021
@mikachan
Copy link
Member

This will be fixed with WordPress/gutenberg#37412, which is due to go into GB 12.3, so I think this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants