Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] Re add the default colour palette and gradients #25523

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

enejb
Copy link
Contributor

@enejb enejb commented Sep 21, 2020

Description

Fixes wordpress-mobile/gutenberg-mobile#2649

By adding the default colour palette and gradients back to the mobile side that were removed on the web side in #25419

How has this been tested?

I tested in on the GB Mobile demo app.

Screenshots

Screen Shot 2020-09-21 at 4 23 04 PM
Screen Shot 2020-09-21 at 4 22 37 PM

Types of changes

Fixes a regression in terms of default color palette and gradients.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@enejb enejb added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Sep 21, 2020
@enejb enejb self-assigned this Sep 21, 2020
@github-actions
Copy link

github-actions bot commented Sep 21, 2020

Size Change: 0 B

Total Size: 1.17 MB

ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.52 kB 0 B
build/api-fetch/index.js 3.34 kB 0 B
build/autop/index.js 2.72 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 8.53 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-editor/index.js 128 kB 0 B
build/block-editor/style-rtl.css 11.1 kB 0 B
build/block-editor/style.css 11.1 kB 0 B
build/block-library/editor-rtl.css 8.56 kB 0 B
build/block-library/editor.css 8.56 kB 0 B
build/block-library/index.js 135 kB 0 B
build/block-library/style-rtl.css 7.6 kB 0 B
build/block-library/style.css 7.59 kB 0 B
build/block-library/theme-rtl.css 741 B 0 B
build/block-library/theme.css 741 B 0 B
build/block-serialization-default-parser/index.js 1.78 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 47.5 kB 0 B
build/components/index.js 167 kB 0 B
build/components/style-rtl.css 15.5 kB 0 B
build/components/style.css 15.5 kB 0 B
build/compose/index.js 9.42 kB 0 B
build/core-data/index.js 12 kB 0 B
build/data-controls/index.js 1.27 kB 0 B
build/data/index.js 8.43 kB 0 B
build/date/index.js 31.9 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 568 B 0 B
build/dom/index.js 4.42 kB 0 B
build/edit-navigation/index.js 10.4 kB 0 B
build/edit-navigation/style-rtl.css 868 B 0 B
build/edit-navigation/style.css 871 B 0 B
build/edit-post/index.js 306 kB 0 B
build/edit-post/style-rtl.css 6.24 kB 0 B
build/edit-post/style.css 6.23 kB 0 B
build/edit-site/index.js 19.7 kB 0 B
build/edit-site/style-rtl.css 3.3 kB 0 B
build/edit-site/style.css 3.3 kB 0 B
build/edit-widgets/index.js 17.5 kB 0 B
build/edit-widgets/style-rtl.css 2.8 kB 0 B
build/edit-widgets/style.css 2.8 kB 0 B
build/editor/editor-styles-rtl.css 492 B 0 B
build/editor/editor-styles.css 493 B 0 B
build/editor/index.js 45.5 kB 0 B
build/editor/style-rtl.css 3.8 kB 0 B
build/editor/style.css 3.8 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.49 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 1.74 kB 0 B
build/html-entities/index.js 621 B 0 B
build/i18n/index.js 3.55 kB 0 B
build/is-shallow-equal/index.js 709 B 0 B
build/keyboard-shortcuts/index.js 2.39 kB 0 B
build/keycodes/index.js 1.85 kB 0 B
build/list-reusable-blocks/index.js 3.02 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.12 kB 0 B
build/notices/index.js 1.69 kB 0 B
build/nux/index.js 3.27 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.44 kB 0 B
build/primitives/index.js 1.34 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 13.7 kB 0 B
build/server-side-render/index.js 2.61 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.24 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.74 kB 0 B
build/warning/index.js 1.13 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action

@pinarol
Copy link
Contributor

pinarol commented Sep 22, 2020

Thanks for the quick fix @enejb. Could you also open an issue to discuss the more ideal solution where we read the default colors/gradients from its new place(theme.json)?

@enejb
Copy link
Contributor Author

enejb commented Sep 22, 2020

@pinarol Here the issue to discuss an alternative solution. #25536

@enejb enejb changed the title Re add the default pallet and gradients Re add the default colour palette and gradients Sep 22, 2020
Copy link
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using the demo app on Android it's working for me 👍 Thanks for the fix here. I think this branch just needs to be updated with the adding back in of the fonts.

@enejb enejb changed the title Re add the default colour palette and gradients [Mobile] Re add the default colour palette and gradients Sep 23, 2020
@enejb enejb force-pushed the RN/add-default-colours-and-gradients branch from dc64215 to 2a4a7e3 Compare September 23, 2020 22:42
@enejb enejb force-pushed the RN/add-default-colours-and-gradients branch from 2a4a7e3 to c97c029 Compare September 23, 2020 22:56
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like you mention in wordpress-mobile/gutenberg-mobile#2649 (comment), I'm also still seeing the Cancel and Apply buttons go missing. I don't see a problem in the current WPiOS 15.7 app. I can file a separate issue so that this PR can close wordpress-mobile/gutenberg-mobile#2649, is that OK?

I also noticed a separate issue where I can't add text to Button blocks (I'll update with a link to an issue once it's created updated) — but the issue is not related to this PR (it's also present on the master branch).

@enejb enejb merged commit 2149b4e into master Sep 24, 2020
@enejb enejb deleted the RN/add-default-colours-and-gradients branch September 24, 2020 15:57
@github-actions github-actions bot added this to the Gutenberg 9.1 milestone Sep 24, 2020
@guarani
Copy link
Contributor

guarani commented Sep 25, 2020

I can file a separate issue so that this PR can close wordpress-mobile/gutenberg-mobile#2649, is that OK?

I filed a separate issue #25646 for the missing "Cancel" and "Apply" buttons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Gradient Color Defaults after web change
4 participants