Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the default colour and gradients to come from theme.js for demo app. #25536

Closed
enejb opened this issue Sep 22, 2020 · 1 comment
Closed

Update the default colour and gradients to come from theme.js for demo app. #25536

enejb opened this issue Sep 22, 2020 · 1 comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)

Comments

@enejb
Copy link
Contributor

enejb commented Sep 22, 2020

Currently on mobile the default colors and gradients are not there any more in the demo app.

#25523 try to fix it by adding the colour back to the default settings that are mobile only.

Where should we read the default color options? Should it be from the theme.json file?

The PR that removed the default settings was #25419.
@enejb enejb added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Sep 22, 2020
@enejb enejb mentioned this issue Sep 22, 2020
Merged
6 tasks
@mtias
Copy link
Member

mtias commented Jul 14, 2021

This seems handled. Feel free to reopen otherwise.

@mtias mtias closed this as completed Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@enejb @mtias