Remove the textdomain from block library

[notnownikki]

Fixes: #12167

[gziolo]

Nice one, thanks 👍

[notnownikki]

This fails the lint checks though, do we need to remove that check?

[gziolo]

Google says you can disable them: https://github.com/squizlabs/PHP_CodeSniffer/wiki/Advanced-Usage#ignoring-parts-of-a-file :)

[gziolo]

Let me check what we do in core, maybe we should replace default there instead.

[notnownikki]

Yeah, I'm just thinking that if no domain is the norm from now on because this is going to be merged into core, then we should get rid of the rule altogether, rather than having to have a lint comment every time?

[swissspidy]

Please see this discussion in Slack: https://wordpress.slack.com/archives/C02QB2JS7/p1542804335045200

For strings that are already in core and not needed in the plugin, adding and exclusion to the phpcs config makes sense. So in this case here I'd exclude that file.

Yeah, I'm just thinking that if no domain is the norm from now on because this is going to be merged into core, then we should get rid of the rule altogether, rather than having to have a lint comment every time?

No. Not every string here in the plugin is also in core.

[gziolo]

I would rather exclude the rule in the files where it makes sense using code comment.

[notnownikki]

Thank you both :) I'll exclude with comments.

[pento]

@notnownikki: You should be able to exclude it by adding this to the phpcs.xml.dist file:

<rule ref="WordPress.WP.I18n.MissingArgDomainDefault">
	<exclude-pattern>packages/block-library/src/*</exclude-pattern>
</rule>

[pento]

Feel free to dismiss this block once the // phpcs:ignore comments are replaced with the phpcs.xml.dist config. 🙂

[gziolo]

Cool, thanks Gary for a great hint. Let's fly with that.

[notnownikki]

Great, have replaced the comments :)

Could someone dismiss the block for me? I can't do that.

Fixed