Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the textdomain from dynamic blocks #12167

Closed
pento opened this issue Nov 21, 2018 · 1 comment
Closed

Remove the textdomain from dynamic blocks #12167

pento opened this issue Nov 21, 2018 · 1 comment
Assignees
@notnownikki
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts
Milestone
WordPress 5.0

Comments

@pento
Copy link
Member

pento commented Nov 21, 2018

#12108 replaced the 'gutenberg' textdomain with the 'default' textdomain.

There shouldn't be a textdomain at all in core strings.
@pento pento added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Nov 21, 2018
@pento pento added this to the WordPress 5.0 milestone Nov 21, 2018
@notnownikki notnownikki self-assigned this Nov 22, 2018
notnownikki added a commit that referenced this issue Nov 22, 2018
@notnownikki
Remove the textdomain from block library
40f8126 
Fixes: #12167
@notnownikki notnownikki mentioned this issue Nov 22, 2018
Merged
@notnownikki
Copy link
Member

I removed the domain in #12215 but that causes it to fail lint checks. Not sure how to proceed here, any ideas?

notnownikki added a commit that referenced this issue Nov 22, 2018
@notnownikki
Remove the textdomain from block library (#12215)
abf1b56 
Fixes: #12167
youknowriad pushed a commit that referenced this issue Nov 29, 2018
@notnownikki @youknowriad
Remove the textdomain from block library (#12215)
98597e7 
Fixes: #12167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@notnownikki notnownikki

Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts
Projects
None yet
Milestone
WordPress 5.0
Development

No branches or pull requests
2 participants
@pento @notnownikki