Json fixes (#91) #92
Merged
Json fixes (#91) #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Check.That(responseWithState1).Equals("Test state msg 1"); | ||
|
|
||
| var responseWithState2 = await http.GetStringAsync(url + "/foo"); | ||
| var responseWithState2 = new HttpClient().GetStringAsync(url + "/foo").Result; | ||
| Check.That(responseWithState2).Equals("Test state msg 2"); |
There was a problem hiding this comment.
This assertion fails since responseWithState2 is retrieved using a new HttpClient instance.
There was a problem hiding this comment.
Actually sometimes, I had some failing tests. So I decided to use a new HttpClient each time, which should works fine because it does not matter who calls the server; the server should track state.
The issue could be related to the order and if the mappings are correctly added before the clients connect maybe????
| @@ -69,7 +70,7 @@ public class StatefulBehaviorTests : IDisposable | |||
| } | |||
|
|
|||
| [Fact] | |||
| public async Task Scenario_and_State_TodoList_Example() | |||
| public void Scenario_and_State_TodoList_Example() | |||
There was a problem hiding this comment.
I believe async Task (and await within the test) was actually better here, or am I missing something here?
There was a problem hiding this comment.
Design is better yes, however they failed sometimes (at my machine...)
joostvanhassel
approved these changes
Feb 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.