Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: WireMock.Net is not matching application/json http requests using JSONPathMatcher #91

Closed
aledaccas opened this issue Feb 19, 2018 · 6 comments
Assignees
Labels

Comments

@aledaccas
Copy link

The JSONPathMatcher does not match a json body request. (Using the IRequestBuilder .WithBody())
This is because the RequestMessageBodyMatcher only uses the .Body property and not the .BodyAsJson property.
to get working, either Body and BodyAsJson must be filled with the body string from request.

@StefH StefH self-assigned this Feb 19, 2018
@StefH StefH changed the title Wiremock.net is not matching application/json http requests Bug: WireMock.Net is not matching application/json http requests using JSONPathMatcher Feb 19, 2018
@StefH StefH added the bug label Feb 19, 2018
@StefH
Copy link
Collaborator

StefH commented Feb 20, 2018

This was broken during the last changes. I will take a look.

@StefH
Copy link
Collaborator

StefH commented Feb 21, 2018

Hello @aledaccas

I did fix it, however, can you please take a look at my code https://github.com/WireMock-Net/WireMock.Net/compare/json?expand=1 before I commit and create a new NuGet ?

@joostvanhassel
Copy link

@StefH Is it possible to open a PR, so conversation on the changes is easy?

@StefH
Copy link
Collaborator

StefH commented Feb 22, 2018

@joostvanhassel I did add you as reviewer to a the PR.
#92

@aledaccas
Copy link
Author

aledaccas commented Feb 22, 2018 via email

@aledaccas
Copy link
Author

aledaccas commented Feb 22, 2018 via email

StefH added a commit that referenced this issue Feb 23, 2018
* Fixes for JsonPath

* More tests

* Fixes + added tests
@StefH StefH closed this as completed Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants