-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: WireMock.Net is not matching application/json http requests using JSONPathMatcher #91
Labels
Comments
This was broken during the last changes. I will take a look. |
Hello @aledaccas I did fix it, however, can you please take a look at my code https://github.com/WireMock-Net/WireMock.Net/compare/json?expand=1 before I commit and create a new NuGet ? |
Closed
@StefH Is it possible to open a PR, so conversation on the changes is easy? |
@joostvanhassel I did add you as reviewer to a the PR. |
Hi Stef I’ll take a look today.
Regards,
|
Stef,
I’d a look and for me It’s ok.
You’ve created more interfaces inheriting from IMatcher passing object as parameter for IsMatch method, adjusted the Matchers and changed the RequestMessage*Matcher classes to adapt to this new matchers. Sweet! ☺
Regards.
Aledaccas
From: Alexandre Daccas Mendonça
Sent: quinta-feira, 22 de fevereiro de 2018 09:14
To: 'WireMock-Net/WireMock.Net' <[email protected]>; WireMock-Net/WireMock.Net <[email protected]>
Cc: Mention <[email protected]>
Subject: RE: [WireMock-Net/WireMock.Net] Bug: WireMock.Net is not matching application/json http requests using JSONPathMatcher (#91)
Hi Stef I’ll take a look today.
Regards,
|
StefH
added a commit
that referenced
this issue
Feb 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The JSONPathMatcher does not match a json body request. (Using the IRequestBuilder .WithBody())
This is because the RequestMessageBodyMatcher only uses the .Body property and not the .BodyAsJson property.
to get working, either Body and BodyAsJson must be filled with the body string from request.
The text was updated successfully, but these errors were encountered: