Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifying val_set, renaming X_intact, and adding unit tests for the visual package #275

Merged
merged 5 commits into from
Dec 18, 2023

Conversation

WenjieDu
Copy link
Owner

What does this PR do?

  1. fixing Simplify the structure of val_set #271;
  2. fixing Make the framework using a consistent strategy when lazy-loading val_set #270;
  3. fixing The name of X_intact may be confusing #273;
  4. writing unit testing cases for visualization functions and adding matplotlib as a dependency;

Before submitting

  • This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

… when lazy-loading val_set (#272)

* feat: make val_set able to use lazy-loading for imputation models;

* feat: simplify val_set structure;

* feat: pip install the local version of pypots for testing;
Renaming X_intact into X_ori, and adding matplotlib as a dependency
@WenjieDu WenjieDu added this to the v0.3 milestone Dec 18, 2023
@WenjieDu WenjieDu merged commit b6adbac into main Dec 18, 2023
7 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant