Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The name of X_intact may be confusing #273

Closed
WenjieDu opened this issue Dec 18, 2023 · 0 comments
Closed

The name of X_intact may be confusing #273

WenjieDu opened this issue Dec 18, 2023 · 0 comments
Assignees
@WenjieDu
Labels
question Further information is requested
Milestone
v0.3

Comments

@WenjieDu
Copy link
Owner

WenjieDu commented Dec 18, 2023 •
edited
Loading

Issue description

In PyPOTS, X is always for model input, and may contain original missing values or artificially designed and added missingness. X_intact is the original time series data only contains original missing data if any, and it is for error or loss calculation. But the word intact in its name may make users think it shouldn't have originally missing values. Hence, we should rename the term X_intact into X_ori which stands for X original.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WenjieDu WenjieDu

Labels
question Further information is requested
Projects
None yet
Milestone
v0.3
Development

No branches or pull requests
1 participant
@WenjieDu