Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #140 utterance true turn to boolean #141

Merged
merged 1 commit into from
Mar 30, 2020
Merged

fix #140 utterance true turn to boolean #141

merged 1 commit into from
Mar 30, 2020

Conversation

rmberrios
Copy link
Contributor

No description provided.

codeclimate[bot]
codeclimate bot reviewed Mar 27, 2020
View reviewed changes
src/connectors/utils.ts
@@ -37,25 +37,31 @@ export function findSheetType(spreadsheet: IVoxaSheet): IVoxaSheet | undefined {
return undefined;
}

export function rowFormatted(acc: any[], next: any, iindex: number, arr: any[]) {
export function rowFormatted(
acc: any[],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function rowFormatted has 5 arguments (exceeds 4 allowed). Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Mar 27, 2020

Code Climate has analyzed commit 79160ac and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3
Duplication 2

View more on Code Climate.

wuelcas
wuelcas reviewed Mar 27, 2020
View reviewed changes
Copy link
Contributor

@wuelcas wuelcas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, in order for this work, we need to set a reestrictFormat column?

@rmberrios
Copy link
Contributor Author

rmberrios commented Mar 27, 2020 •
edited
Loading

@wuelcas No, actually that value is to check if the row is an Utterance tab, no need to specify it

@rmberrios rmberrios merged commit 0b41152 into VoxaAI:staging Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate left review comments

@wuelcas wuelcas wuelcas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rmberrios @wuelcas