Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utterance samples of intents with yes/no change to true/false #140

Closed
patcat opened this issue Mar 2, 2020 · 3 comments
Closed

Utterance samples of intents with yes/no change to true/false #140

patcat opened this issue Mar 2, 2020 · 3 comments

Comments

@patcat
Copy link

patcat commented Mar 2, 2020

It seems to be a part of a change to support Office 365, but in /src/connectors/utils.ts it looks like values of "yes" and "no" are changed to true and false?

When we have "yes" and "no" in our Google spreadsheet as responses to YesIntent and NoIntent, they get replaced when imported in... which isn't desired!

Any info on why this functionality has specifically been put in there? Am I missing something?

Thanks!

@patcat
Copy link
Author

patcat commented Mar 3, 2020

Also, having "false" as an utterance entry gets removed in the generated JSON too?

@rmberrios
Copy link
Contributor

We do it for the download feature(DOWNLOAD_TAB), but it shouldn't change those utterances in the Intent. I'm going to address this. Since we use AMAZON.YesIntent and AMAZON.NoIntent we didn't have any problem.

@patcat
Copy link
Author

patcat commented Mar 4, 2020

Fantastic thanks — if you have a PR for the change when you've been able to address it and you need a hand testing it out, I can test it on our spreadsheet.

rmberrios added a commit to rmberrios/voxa-cli that referenced this issue Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants