Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin): User Voice Show #694

Merged
merged 37 commits into from
Apr 6, 2023
Merged

feat(plugin): User Voice Show #694

merged 37 commits into from
Apr 6, 2023

Conversation

LordEliasTM
Copy link
Contributor

Shows in which voice channel a user is.
If you click the button with the channel name you can join the voice if you have sufficient permissions to the channel.
Strongly inspired by the BetterDiscord version of this plugin.

image
image

@Vendicated
Copy link
Owner

The ui for this looks very foreign, it doesn't fit into Discord at all. I would make it look similar to activities. I think that's what the BD plugin does? Perhaps you could look at it for inspiration

@LordEliasTM
Copy link
Contributor Author

I just copy pasted the style from the original plugin. However what do you mean with the activities?

@AutumnVN
Copy link
Contributor

i think he means this https://betterdiscord.app/plugin/VoiceActivity

@LordEliasTM
Copy link
Contributor Author

Well to make it more fitting into discord, I'd make it a normal button instead of custom. However it'd look weird on the user profile modal.

@LordEliasTM
Copy link
Contributor Author

Also I intended the design to be more subtile, as the custom button matches the background when not hovered over.

@LordEliasTM
Copy link
Contributor Author

I think that's what the BD plugin does?

i think he means this https://betterdiscord.app/plugin/VoiceActivity

I based it on https://betterdiscord.app/plugin/UserVoiceShow, not VoiceActivity

@LordEliasTM
Copy link
Contributor Author

Hope that looks native enough.
Added a title and changed my custom button to a native one.
image

src/plugins/userVoiceShow/index.tsx Outdated Show resolved Hide resolved
src/plugins/userVoiceShow/index.tsx Outdated Show resolved Hide resolved
src/plugins/userVoiceShow/index.tsx Outdated Show resolved Hide resolved
src/plugins/userVoiceShow/index.tsx Outdated Show resolved Hide resolved
src/plugins/userVoiceShow/index.tsx Outdated Show resolved Hide resolved
Nuckyz
Nuckyz previously requested changes Apr 3, 2023
src/plugins/userVoiceShow/index.tsx Outdated Show resolved Hide resolved
src/plugins/userVoiceShow/index.tsx Outdated Show resolved Hide resolved
@Vendicated Vendicated merged commit e261c93 into Vendicated:main Apr 6, 2023
@pinetreemoonlight
Copy link

pinetreemoonlight commented Apr 30, 2024

Hey, hope it's fine that I'm posting here. I have a feature request about your awesome plugin:

  1. incorporate friend list voice activity icon
  2. incorporate individual user's DM panel right-hand side panel voice activity

These two features are present in BetterDiscord's VoiceActivity plugin by Neodymium: https://github.com/Neodymium7/BetterDiscordStuff/blob/main/VoiceActivity/VoiceActivity.plugin.js

Would this be possible?

Friend list voice activity:
Screenshot 2024-04-30 at 06 42 28

DM right-hand side panel voice activity:
Screenshot 2024-04-30 at 06 42 56

@LordEliasTM
Copy link
Contributor Author

Exactly, I've already continued plugin development in private, as the Vencord devs seem to ignore my pull requests, so I just gave up. Already added features like a button to just view the channel and a speaker icon next to names of friends who are in a voice.

@D3SOX
Copy link
Sponsor Contributor

D3SOX commented Apr 30, 2024

I gave up waiting for my PRs as well, but I provide them as userplugins now. It would be great if you could do that with the latest version of your plugin too

@LordEliasTM
Copy link
Contributor Author

Sure,
userVoiceShow2.zip

@LordEliasTM
Copy link
Contributor Author

Bruh, any errors?

@pinetreemoonlight
Copy link

pinetreemoonlight commented May 1, 2024

Bruh, any errors?

ok so it works great on member/friends list, but it's not visible on individual DM's right-hand side panel

@practiceineverything
Copy link

Bruh, any errors?

It's not working at the moment, can you fix it please.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants