Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin(userVoiceShow): Add voice activity status icons in Member and DM list #1669

Open
wants to merge 107 commits into
base: main
Choose a base branch
from

Conversation

Johannes7k75
Copy link

Adds Activity Icons from the BD plugin which was created by Neodymium

@TheKodeToad
Copy link
Contributor

Surely it wouldn't be too hard to make this without copying parts of it?

@Johannes7k75
Copy link
Author

My question is maybe dumb, but why? His licence states that the code can be reused.

@Methosss
Copy link

speaker icon next to the nickname with hover to see where he is would be great

@TheKodeToad
Copy link
Contributor

My question is maybe dumb, but why? His licence states that the code can be reused.

That doesn't mean you should just take it (I didn't look too closely though)

@Vendicated
Copy link
Owner

That doesn't mean you should just take it (I didn't look too closely though)

Why not?

@Johannes7k75
Copy link
Author

speaker icon next to the nickname with hover to see where he is would be great

Where should the icon be? (Maybe a screenshot?)

@TheKodeToad
Copy link
Contributor

That doesn't mean you should just take it (I didn't look too closely though)

Why not?

i'm a bit late lol
imo copying something isn't much fun - and if it's done without permission or credit in the ui the developer probably won't like it

@Marocco2
Copy link
Contributor

Marocco2 commented Sep 22, 2023

That doesn't mean you should just take it (I didn't look too closely though)

Why not?

i'm a bit late lol imo copying something isn't much fun - and if it's done without permission or credit in the ui the developer probably won't like it

It's MIT licensed and he already posted the license on the first commit in PR, so it's good (he doesn't need futher permissions because they are already granted by this very license)

@slikie
Copy link

slikie commented Sep 30, 2023

Where should the icon be? (Maybe a screenshot?)

How about something like this? plugin from https://betterdiscord.app/plugin/VoiceActivity
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants