fix: blast weth address #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Graphite Automations"Request reviewers once CI passes on smart-order-router repo" took an action on this PR • (05/23/24)3 reviewers were added and 1 assignee was added to this PR based on 's automation. |
cgkol
approved these changes
May 23, 2024
Merged
jsy1218
added a commit
that referenced
this pull request
May 23, 2024
- **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...) Release #588
jsy1218
added a commit
to Uniswap/routing-api
that referenced
this pull request
May 23, 2024
routing-api pipeline failed. Sepolia failed because health state DB has ALCHEMY_11155111 unhealthy in the DB record, but the code doesn't update the DB state back to healthy for some reason. I removed the code reads from health state DB, so that the provider health state transition doesn't happen at runtime. Blast failed because of wrong weth address that impacts v3 gas model. Fixed in Uniswap/smart-order-router#588
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
I saw routing-api pipeline failed with blast tests. Digging into it, it's because blast weth address is wrong to compute v3 gas model.
What is the new behavior (if this is a feature change)?
Fix blast weth address.
Other information:
This only impacts the route going through v3. For v2 route, since we don't compute the WETH/USDC gas model, the quote can still work.