Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sepolia and blast integ-tests #708

Merged
merged 4 commits into from
May 23, 2024
Merged

Conversation

jsy1218
Copy link
Member

@jsy1218 jsy1218 commented May 23, 2024

routing-api pipeline failed.

Sepolia failed because health state DB has ALCHEMY_11155111 unhealthy in the DB record, but the code doesn't update the DB state back to healthy for some reason. I removed the code reads from health state DB, so that the provider health state transition doesn't happen at runtime.

Blast failed because of wrong weth address that impacts v3 gas model. Fixed in Uniswap/smart-order-router#588

Copy link
Member Author

jsy1218 commented May 23, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jsy1218 and the rest of your teammates on Graphite Graphite

@jsy1218 jsy1218 changed the title do not sync to health state db fix: sepolia and blast integ-tests May 23, 2024
@jsy1218 jsy1218 marked this pull request as ready for review May 23, 2024 14:15
Copy link

socket-security bot commented May 23, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@uniswap/[email protected] Transitive: environment, eval, filesystem, network, shell +106 116 MB

🚮 Removed packages: npm/@uniswap/[email protected], npm/@uniswap/[email protected]

View full report↗︎

@graphite-app graphite-app bot requested review from mikeki, uni-guillaume, cgkol and a team May 23, 2024 14:46
Copy link
Collaborator

@cgkol cgkol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call

Copy link

graphite-app bot commented May 23, 2024

Graphite Automations

"Request reviewers once CI passes on routing-api repo" took an action on this PR • (05/23/24)

5 reviewers were added and 1 assignee was added to this PR based on 's automation.

Copy link
Member Author

jsy1218 commented May 23, 2024

They can now pass against my local routing-api lambda https://app.warp.dev/block/5NhddSlfqmCc80dvdo70xA

@jsy1218 jsy1218 merged commit 6b43be9 into main May 23, 2024
5 checks passed
@jsy1218 jsy1218 deleted the jsy1218/fix-sepolia-and-blast branch May 23, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants