Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving gas estimates for l2s #53

Merged
merged 14 commits into from
Feb 1, 2022
Merged

Improving gas estimates for l2s #53

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d9ab147
adding optimism l1 security fee to gas estimates
snreynolds Jan 21, 2022
3ae60e3
Fix code style issues with Prettier
lint-action Jan 21, 2022
cc3a85f
fix: ensure compatibility with v2
snreynolds Jan 25, 2022
4393d04
Merge branch 'gas-estimate-improvements' of https://github.com/Uniswa…
snreynolds Jan 25, 2022
b820e78
fix: default to v3 when no protocol specified
snreynolds Jan 25, 2022
99babc8
update arbgas numbers and remove config changes
snreynolds Jan 26, 2022
1e0fd61
test cleanup and fix comile issue
snreynolds Jan 26, 2022
2b671b0
cleanup and comments
snreynolds Jan 26, 2022
2f6af8b
remove comments
snreynolds Jan 26, 2022
b7b9fbb
add multicall function and change provider name
snreynolds Jan 31, 2022
679d9b0
remove and rename variables, add dummy swap config
snreynolds Jan 31, 2022
00d574e
remove logs
snreynolds Feb 1, 2022
fefaf64
fixing merge conflicts
snreynolds Feb 1, 2022
3de4a88
rremove 02 typeing
snreynolds Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove comments
  • Loading branch information
@snreynolds
snreynolds committed Jan 26, 2022
commit 2f6af8b369c50bd0164830211a525fac0a316f7d
8 changes: 4 additions & 4 deletions cli/commands/quote.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { flags } from '@oclif/command';
import { Protocol } from '@uniswap/router-sdk';
import { Currency, Percent, TradeType } from '@uniswap/sdk-core';
import dotenv from 'dotenv';
import { ethers } from 'ethers';
import { BigNumber, ethers } from 'ethers';
import _ from 'lodash';
import {
ID_TO_CHAIN_ID,
Expand Down Expand Up @@ -201,9 +201,9 @@ export class Quote extends BaseCommand {
blockNumber,
estimatedGasUsed,
gasPriceWei,
initTicksCrossed!,
l1GasUse!,
l1GasCost!
initTicksCrossed ?? BigNumber.from(0),
l1GasUse ?? BigNumber.from(0),
l1GasCost ?? BigNumber.from(0)!
);
}
}
2 changes: 1 addition & 1 deletion src/providers/v3/gas-data-provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { GasPriceOracle, GasPriceOracle__factory } from '../../types/other';
import { ChainId, OVM_GASPRICE_ADDRESS } from '../../util';

/**
* Provider or getting Optimism gas constants.
* Provider for getting Optimism gas constants.
*
* @export
* @interface IGasDataProvider
Expand Down
2 changes: 0 additions & 2 deletions src/routers/alpha-router/gas-models/v3/v3-heuristic-gas-model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,8 +239,6 @@ export class V3HeuristicGasModelFactory extends IV3GasModelFactory {
};
}

// NOTE end of buildGasModel()

private estimateGas(
routeWithValidQuote: V3RouteWithValidQuote,
gasPriceWei: BigNumber,
Expand Down