Improving gas estimates for l2s #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p/smart-order-router into gas-estimate-improvements
willpote
reviewed
Jan 27, 2022
src/routers/alpha-router/gas-models/v3/v3-heuristic-gas-model.ts
Outdated
Show resolved
Hide resolved
src/routers/alpha-router/gas-models/v3/v3-heuristic-gas-model.ts
Outdated
Show resolved
Hide resolved
src/routers/alpha-router/gas-models/v3/v3-heuristic-gas-model.ts
Outdated
Show resolved
Hide resolved
src/routers/alpha-router/gas-models/v3/v3-heuristic-gas-model.ts
Outdated
Show resolved
Hide resolved
willpote
approved these changes
Feb 1, 2022
cli/base-command.ts
Outdated
Comment on lines
329
to
330
| `Total initialized ticks crossed ${v3Route.initializedTicksCrossedList.length}` | ||
| ); |
There was a problem hiding this comment.
Each element in the initializedTIcksCrossedList is the number of ticks crossed for each pool so you need to sum them
There was a problem hiding this comment.
Right! Actually these can just be deleted - I just needed these data points when I was manual testing with arbirtrum and optimism (and I was only ever looking at a swap with 1 route).
If you think these are good to print out though in general, I can change it back to summing over all the routes.
cli/base-command.ts
Outdated
| @@ -318,5 +320,14 @@ export abstract class BaseCommand extends Command { | |||
| estimatedGasUsed: estimatedGasUsed.toString(), | |||
| gasPriceWei: gasPriceWei.toString(), | |||
| }); | |||
| const hops = routeAmounts[0]?.poolAddresses.length; | |||
There was a problem hiding this comment.
Have to sum across all the routeAmounts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noteable changes:
buildTradeandbuildSwapMethodParametersto a separate library so we can access them in the gasModelinitTicksCrossed,gasUseL1, andgasCostL1to the logger so they’re printed at each run of the router (this was to help with manual gas estimation testing but can definitely be removed)