SDW ExpirationDate refactor #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test: additional test for estimatedRemovalDate inclusion chore: updated readme to reflect rename
|
Sonar appears to be failing with a Java version error, I don't believe this is in my court, but let me know if I need to do something. The version of Java (11.0.17) used to run this analysis is deprecated, and SonarCloud no longer supports it. Please upgrade to Java 17 or later. |
9 tasks
dmccoystephenson
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename property passed to KafkaConsumerRestDepositor and through to the SDX from expirationDate to estimatedRemovalDate. Additional test for passing expirationRemovalDate, and update of ReadMe.