Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/sdw expiration meta data #7

Merged
merged 9 commits into from
Jan 29, 2024
Merged

Conversation

Ryan-Roan
Copy link

@Ryan-Roan Ryan-Roan commented Dec 4, 2023

PR Details

Addition of Expiration Date meta data for tracking in the SDW.

PR Detail Note: This PR is dependent upon a change to the SDWD also in the Trihydro branches.
Trihydro/jpo-sdw-depositor#9

Additional field expireDate added to the SituationDataWarehouse object. Alterations to EncodedDataRouter to utilize new information and pass it along to consumers of the Sdw. Specifically ASN1CommandManager.depositToSdw.

Related Issue

Currently no known issue.

Motivation and Context

ASN1 formatting only allows for TIM data objects to have a duration of a maximum ~22 days. DOT facilities have a need to represent TIM advisories for a longer period than can be managed through the encoding alone. As DOT facilities often know there is an extended expiration, we would like to provide the ability to store the correct expiration date, while maintaining the correct encoding practices of ASN1 for all encodable information.

How Has This Been Tested?

Ran the TIM_Message_Testing_Files suite both with and without the changes to the Command manager to show matching results. Ran the existing Maven tests to verify depositToSdw test passes as expected. Added additional Maven test passing json object to verify form.

Testing environment was VS Code running provided .devcontainer.

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    ODE Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Ryan-Roan Ryan-Roan marked this pull request as ready for review December 11, 2023 18:12
Copy link
Member

@dmccoystephenson dmccoystephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, and the unit tests pass!

I just had one clarifying question.

Copy link

@payneBrandon payneBrandon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@payneBrandon payneBrandon merged commit 14cd3de into develop Jan 29, 2024
2 of 4 checks passed
@payneBrandon payneBrandon deleted the feat/SDWExpirationMetaData branch January 29, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants