Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: CamelCase -> UpperCamelCase #623

Merged
merged 5 commits into from
Apr 10, 2024
Merged

docs: CamelCase -> UpperCamelCase #623

merged 5 commits into from
Apr 10, 2024

Conversation

andretchen0
Copy link
Contributor

Problem

It was pointed out that ...

<TresTagName />

... is not "CamelCase" by some definitions.

Other names often used when there's an initial capital letter:

  • PascalCase
  • UpperCamelCase
  • CapitalizedWords
  • CapWords

Solution

To clear up the possible misunderstandings, this PR swaps "CamelCase" for "UpperCamelCase" in the docs.


Closes #621

Copy link

netlify bot commented Apr 7, 2024

Deploy Preview for tresjs-docs ready!

Name Link
🔨 Latest commit 66ea794
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-docs/deploys/661636e6b378ab0008aaa51e
😎 Deploy Preview https://deploy-preview-623--tresjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@alvarosabu alvarosabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point, although I think changing to PascalCase is more appropriate since is widely used in programming rather than UpperCamelCase.

@andretchen0
Copy link
Contributor Author

PascalCase

Sure thing. Done.

@alvarosabu alvarosabu merged commit 5bdf251 into main Apr 10, 2024
7 checks passed
@alvarosabu alvarosabu deleted the docs/camel-case-wording branch April 10, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor error in docs- ThisIsPascalCase and thisIsCamelCase
2 participants