Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor error in docs- ThisIsPascalCase and thisIsCamelCase #621

Closed
5 tasks done
jonmatthis opened this issue Apr 5, 2024 · 3 comments · Fixed by #623
Closed
5 tasks done

Minor error in docs- ThisIsPascalCase and thisIsCamelCase #621

jonmatthis opened this issue Apr 5, 2024 · 3 comments · Fixed by #623
Labels
docs Improvements or additions to documentation p1-chore Doesn't change end-user code behavior (priority)

Comments

@jonmatthis
Copy link

Describe the bug

In the 'your first scene' doc, you say the 'TresAmbientLight' is camel case. Technically it is PascalCase 😌

Reproduction

https://docs.tresjs.org/guide/your-first-scene.html

Steps to reproduce

  1. Look at words.
  2. Think of their definitions.
  3. Be super pendantic
  4. Clutch pearls 😱

System Info

No response

Used Package Manager

npm

Code of Conduct

@andretchen0
Copy link
Contributor

andretchen0 commented Apr 6, 2024

Context

ThisSortOfCasing is called:

If we're going to change the wording to be more specific, I'd personally prefer 'UpperCamelCase' or 'CamelCaps'; 'PascalCase' isn't evocative to me.

@jonmatthis
Copy link
Author

Oh, I didn't realize there was inconsistency there! Thanks for clarifying.

I agree - the term PascalCase always stood out as a weirdly non-evocative term amid the lovely pantheon of camelCase, kebab-case, snake-case, and (my personal favorite) SCREAMING_SNAKE_CASE

Like, who th is this Pascal guy? Like the gas science guy? What's he got to do with capitalization?

UpperCamelCase seems like the good choice.

Thanks for your work!

@andretchen0
Copy link
Contributor

What's he got to do with capitalization?

Origin of 'PascalCase' as a term in computer programming.


Fwiw, I filed a PR changing "CamelCase" to "UpperCamelCase" in the docs.

@alvarosabu alvarosabu added docs Improvements or additions to documentation p1-chore Doesn't change end-user code behavior (priority) labels Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation p1-chore Doesn't change end-user code behavior (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants