[Enhancement] adjust drop_tablet_worker_count to half of the core number by default #52246
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: srlch <[email protected]>
ac453ba
to
0d33e4b
Compare
Signed-off-by: srlch <[email protected]>
Signed-off-by: srlch <[email protected]>
Signed-off-by: srlch <[email protected]>
Signed-off-by: srlch <[email protected]>
Signed-off-by: srlch <[email protected]>
kevincai
previously approved these changes
Nov 18, 2024
wyb
reviewed
Nov 18, 2024
Signed-off-by: srlch <[email protected]>
wyb
previously approved these changes
Nov 20, 2024
Signed-off-by: srlch <[email protected]>
auto-merge was automatically disabled
November 22, 2024 02:02
Head branch was pushed to by a user without write access
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]❌ fail : 3 / 8 (37.50%) file detail
|
kevincai
approved these changes
Nov 22, 2024
wyb
approved these changes
Nov 22, 2024
|
@Mergifyio backport branch-3.4 |
|
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
…ber by default (#52246) Signed-off-by: srlch <[email protected]> (cherry picked from commit 8e9102f)
43 tasks
mergify bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
…ber by default (#52246) Signed-off-by: srlch <[email protected]> (cherry picked from commit 8e9102f)
43 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Nov 22, 2024
…ber by default (backport #52246) (#53124) Co-authored-by: srlch <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Nov 22, 2024
…ber by default (backport #52246) (#53125) Co-authored-by: srlch <[email protected]>
Smith-Cruise
pushed a commit
to Smith-Cruise/starrocks
that referenced
this pull request
Nov 26, 2024
…ber by default (StarRocks#52246) Signed-off-by: srlch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
In shared data mode, file gc relies on the efficiency of the delete file thread pool. The default thread pool size is too small, which causes the delete file task queue to accumulate easily under high ingestion concurrency or under large ingestion, resulting in slowing donw vacuum task.
What I'm doing:
In the pr, we slightly increase the delete file thread pool size into half the cpu core (
config::drop_tablet_worker_count <= 0) If user change theconfig::drop_tablet_worker_count <= 0at runtime, the thread pool size will also be modified as half the cpu core.Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: