Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] adjust drop_tablet_worker_count to half of the core number by default (backport #52246) #53124

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 22, 2024

Why I'm doing:

In shared data mode, file gc relies on the efficiency of the delete file thread pool. The default thread pool size is too small, which causes the delete file task queue to accumulate easily under high ingestion concurrency or under large ingestion, resulting in slowing donw vacuum task.

What I'm doing:

In the pr, we slightly increase the delete file thread pool size into half the cpu core (config::drop_tablet_worker_count <= 0) If user change the config::drop_tablet_worker_count <= 0 at runtime, the thread pool size will also be modified as half the cpu core.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #52246 done by [Mergify](https://mergify.com). ## Why I'm doing: In shared data mode, file gc relies on the efficiency of the delete file thread pool. The default thread pool size is too small, which causes the delete file task queue to accumulate easily under high ingestion concurrency or under large ingestion, resulting in slowing donw vacuum task.

What I'm doing:

In the pr, we slightly increase the delete file thread pool size into half the cpu core (config::drop_tablet_worker_count <= 0) If user change the config::drop_tablet_worker_count <= 0 at runtime, the thread pool size will also be modified as half the cpu core.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…ber by default (#52246)

Signed-off-by: srlch <[email protected]>
(cherry picked from commit 8e9102f)
@wanpengfei-git wanpengfei-git merged commit 697e3ab into branch-3.4 Nov 22, 2024
32 of 33 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.4/pr-52246 branch November 22, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants