✚ Add type safety to dependencies.implementation() #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow up on #229 It focuses on typesafety only There is an elegant Kotlin solution for every problem. Since implentation is defined like this ``` fun DependencyHandler.`implementation`(dependencyNotation: Any): Dependency? = add("implementation", dependencyNotation) ``` Then we can overwrite this function for when the parameter is IsNotADependency or DependencyNotationAndGroup This way the IDE shows you that made a mistake
jmfayard
changed the title
LouisCAD
requested changes
Aug 30, 2020
plugins/dependencies/src/main/kotlin/dependencies/DependencyNotationAndGroup.kt
Outdated
Show resolved
Hide resolved
LouisCAD
requested changes
Aug 31, 2020
plugins/dependencies/src/main/kotlin/org/gradle/kotlin/dsl/IsNotADependency.kt
Outdated
Show resolved
Hide resolved
|
Something that would be cool it to have a test to ensure we don't forget to extend either |
LouisCAD
requested changes
Aug 31, 2020
plugins/dependencies/src/main/kotlin/org/gradle/kotlin/dsl/IsNotADependency.kt
Outdated
Show resolved
Hide resolved
plugins/dependencies/src/main/kotlin/org/gradle/kotlin/dsl/IsNotADependency.kt
Outdated
Show resolved
Hide resolved
plugins/dependencies/src/main/kotlin/org/gradle/kotlin/dsl/IsNotADependency.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up on #229
It focuses on typesafety only
There is an elegant Kotlin solution for every problem.
The IDE now imports two version of
implementation.Since the second one is more specific, it takes precedence when the parameter is
IsNotADependencyor in practiceDependencyNotationAndGroupThis way the IDE shows you that made a mistake