✚ plural type-safe way of adding dependencies #229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Augment the Kotlin DSL for the block `dependencies { }`
with its plural forms "implementations", "apis", "testImplementations".
For example:
```
dependencies {
implementations(KotlinX.coroutines.core, KotlinX.coroutines.android)
// or
implementations(listOf(KotlinX.coroutines.core, KotlinX.coroutines.android))
}
```
This is both more concise and more type-safe.
`implementation(KotlinX.coroutines)` is wrong but would fail only at runtime because the method accept an object as parameter
LouisCAD
requested changes
Aug 26, 2020
There was a problem hiding this comment.
Having multiple dependencies declarations makes eye scanning harder, as you need to juggle back and forth in addition to scanning down, and you lose the alignment.
The type safety is a nice thing though I like it. I think this is an area that deserves exploration as your proposal is not the only possible solution.
Maybe we should open an issue about that, or discuss this in another channel?
BTW, for future PRs, let's target the develop branch so people always browse the code reflecting the latest stable release by default.
jmfayard
added a commit
that referenced
this pull request
Aug 29, 2020
This is a follow up on #229 It focuses on typesafety only There is an elegant Kotlin solution for every problem. Since implentation is defined like this ``` fun DependencyHandler.`implementation`(dependencyNotation: Any): Dependency? = add("implementation", dependencyNotation) ``` Then we can overwrite this function for when the parameter is IsNotADependency or DependencyNotationAndGroup This way the IDE shows you that made a mistake
jmfayard
added a commit
that referenced
this pull request
Aug 31, 2020
This is a follow up on #229 It focuses on typesafety only There is an elegant Kotlin solution for every problem. The IDE now imports two version of `implementation`. ``` fun DependencyHandler.`implementation`(dependencyNotation: Any): Dependency? = add("implementation", dependencyNotation) @kotlin.Deprecated(ErrorIsNotADependency) fun DependencyHandler.`implementation`(dependencyNotation: IsNotADependency): Dependency? = null ``` Since the second one is more specific, it takes precedence when the parameter is `IsNotADependency` or in practice `DependencyNotationAndGroup` This way the IDE shows you that made a mistake <img width="874" alt="GraySky____IdeaProjects_gray-sky-weather__-_build_gradle_kts___app_" src="https://user-images.githubusercontent.com/459464/91646121-1b9e6180-ea4c-11ea-87b1-c18cd08c63b1.png">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Augment the Kotlin DSL for the block
dependencies { }with its plural forms
implementations,apisandtestImplementations.For example:
This is both more concise and more type-safe.
implementation(KotlinX.coroutines)is wrong but would fail only at runtime because the method accept an object as parameter