rejectVersionIf { } now considers all versions as stable #629
Comments
|
Oh yeah, we need to support number-less versions. Care to add some failing tests in a PR? I'd pick it up from here and fix it the way it should. |
|
Fixed on main, just launched the publication of a new snapshot in case you want to try it before one of use make a new release. |
thederputy
pushed a commit
to thederputy/refreshVersions
that referenced
this issue
Oct 2, 2022
Since last changes in the Version class, versions like 1.7.20-RC and 1.7.20-Beta would be marked as stable instead of respectively ReleaseCandidate and Beta because the logic expected a number in all cases. The number is now optional for all pre-versions, except milestones. To prevent future recurrence of such regression, this commit also adds tests that assert the expected stability level of many known versions from various libraries. Fixes Splitties#629
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐛 Describe the bug
In refreshVersions 0.50.2, all versions are described as stable
Versions like 1.7.20-RC and 1.7.20-Beta are considered stable.
rendering
refreshVersions.rejectVersionIf { .. }useless✅ Expected behavior
Like before
💣 Steps to reproduce
Checkout jmfayard/kotlin-playground@0e07f63
📱 Tech info
https://scans.gradle.com/s/dteblugtek5ec#infrastructure
The text was updated successfully, but these errors were encountered: