-
-
Notifications
You must be signed in to change notification settings - Fork 107
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix StabilityLevel calculation for number-less pre-versions
Since last changes in the Version class, versions like 1.7.20-RC and 1.7.20-Beta would be marked as stable instead of respectively ReleaseCandidate and Beta because the logic expected a number in all cases. The number is now optional for all pre-versions, except milestones. To prevent future recurrence of such regression, this commit also adds tests that assert the expected stability level of many known versions from various libraries. Fixes #629
- Loading branch information
Showing
11 changed files
with
473 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
plugins/core/src/test/resources/versions-stability-level/Alpha.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
// kotlinx.coroutines | ||
0.19-alpha-4 | ||
1.1.0-alpha | ||
1.2.0-alpha | ||
1.2.0-alpha-2 |
14 changes: 14 additions & 0 deletions
14
plugins/core/src/test/resources/versions-stability-level/Beta.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
// Kotlin | ||
1.0.0-beta-1038 | ||
1.0.0-beta-1103 | ||
1.0.0-beta-2417 | ||
1.0.0-beta-2422 | ||
1.0.0-beta-2423 | ||
1.0.0-beta-3593 | ||
1.0.0-beta-3594 | ||
1.0.0-beta-3595 | ||
1.0.0-beta-4583 | ||
1.0.0-beta-4584 | ||
1.0.0-beta-4589 | ||
1.7.0-Beta | ||
1.7.20-Beta |
3 changes: 3 additions & 0 deletions
3
plugins/core/src/test/resources/versions-stability-level/Development.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
0.1.0-dev | ||
0.2.0-dev1 | ||
1.0.0-dev-01 |
10 changes: 10 additions & 0 deletions
10
plugins/core/src/test/resources/versions-stability-level/EarlyAccessProgram.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
// kotlinx.coroutines | ||
0.24.0-eap13 | ||
0.25.0-eap13 | ||
0.25.3-eap13 | ||
0.26.0-eap13 | ||
0.26.1-eap13 | ||
0.27.0-eap13 | ||
0.30.1-eap13 | ||
0.30.2-eap13 | ||
1.1.1-eap13 |
16 changes: 16 additions & 0 deletions
16
plugins/core/src/test/resources/versions-stability-level/Milestone.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
// Kotlin | ||
1.4.20-M1 | ||
1.4.20-M2 | ||
1.4.30-M1 | ||
1.5.0-M1 | ||
1.5.0-M2 | ||
1.5.20-M1 | ||
1.5.30-M1 | ||
1.6.0-M1 | ||
1.6.20-M1 | ||
|
||
// org.eclipse.jgit | ||
3.4.0.201405051725-m7 | ||
3.6.0.201411121045-m1 | ||
4.0.0.201505050340-m2 | ||
5.0.0.201805151920-m7 |
6 changes: 6 additions & 0 deletions
6
plugins/core/src/test/resources/versions-stability-level/Preview.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
1.0.0-preview | ||
2.0.0-preview1 | ||
2.0.0-preview2 | ||
3.0.0-preview-01 | ||
3.0.0-preview-02 | ||
3.0.0-preview-03 |
30 changes: 30 additions & 0 deletions
30
plugins/core/src/test/resources/versions-stability-level/ReleaseCandidate.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
// Kotlin | ||
1.0.0-rc-1036 | ||
1.3.0-rc-190 | ||
1.3.0-rc-198 | ||
1.4.0-rc | ||
1.4.20-RC | ||
1.4.30-RC | ||
1.5.0-RC | ||
1.5.20-RC | ||
1.5.30-RC | ||
1.6.0-RC | ||
1.6.0-RC2 | ||
1.6.10-RC | ||
1.6.20-RC | ||
1.6.20-RC2 | ||
1.7.0-RC | ||
1.7.0-RC2 | ||
1.7.20-RC | ||
|
||
// org.eclipse.jgit | ||
3.4.0.201405211411-rc1 | ||
3.4.0.201405281120-rc2 | ||
3.4.0.201406041058-rc3 | ||
3.5.0.201409071800-rc1 | ||
4.0.0.201505260635-rc2 | ||
4.0.0.201506020755-rc3 | ||
4.4.0.201605250940-rc1 | ||
4.8.0.201705170830-rc1 | ||
5.0.0.201805221745-rc1 | ||
5.0.0.201805301535-rc2 |
2 changes: 2 additions & 0 deletions
2
plugins/core/src/test/resources/versions-stability-level/Snapshot.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
// refreshVersions | ||
0.51.0-SNAPSHOT |
Oops, something went wrong.