Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: remove false positive warning #756

Closed
wants to merge 1 commit into from

Commits on Jul 28, 2017

  1. BUG: remove false positive warning

    As reported by @fedorov, he was getting warning messages about
    bad spacing even for data he thought was correct.  This was
    confirmed with data from series 3 of this [1] dataset.
    
    The problem was some faulty logic that to calculate which
    loadable has the highest priority [2] but we can remove that
    logic because the loadable are already flagged with a
    'selected' attribute and we only need to generate the
    dialog box when a selected loadable has a warning.
    
    Tested with series 1 (with warning) and 3 of [1].
    
    [1] http:https://slicer.kitware.com/midas3/folder/2182
    [2] Slicer/Slicer@c5a92bc
    pieper committed Jul 28, 2017
    Configuration menu
    Copy the full SHA
    e7d0d71 View commit details
    Browse the repository at this point in the history