BUG: remove false positive warning #756
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported by @fedorov, he was getting warning messages about bad spacing even for data he thought was correct. This was confirmed with data from series 3 of this [1] dataset. The problem was some faulty logic that to calculate which loadable has the highest priority [2] but we can remove that logic because the loadable are already flagged with a 'selected' attribute and we only need to generate the dialog box when a selected loadable has a warning. Tested with series 1 (with warning) and 3 of [1]. [1] http:https://slicer.kitware.com/midas3/folder/2182 [2] Slicer/Slicer@c5a92bc
fedorov
approved these changes
Jul 28, 2017
|
Committed as r26184 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @fedorov, he was getting warning messages about
bad spacing even for data he thought was correct. This was
confirmed with data from series 3 of this [1] dataset.
The problem was some faulty logic that to calculate which
loadable has the highest priority [2] but we can remove that
logic because the loadable are already flagged with a
'selected' attribute and we only need to generate the
dialog box when a selected loadable has a warning.
Tested with series 1 (with warning) and 3 of [1].
[1] http:https://slicer.kitware.com/midas3/folder/2182
[2] Slicer/Slicer@c5a92bc