Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 10 Requires normalize.css! #16

Closed
mmortazavi opened this issue Aug 14, 2019 · 16 comments
Closed

Windows 10 Requires normalize.css! #16

mmortazavi opened this issue Aug 14, 2019 · 16 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects

Comments

@mmortazavi
Copy link

Thanks for the great tool; well-done, and I will be looking forward to trying out new features.

One note for Windows 10 Users. After following the instructions and successfully installing the make-sense I couldn't view it in the browser (e.g. Google Chrome). Basically npm start in Windows 10 Ubuntu results in the following error in the browser:

Error: Cannot find module '@csstools/normalize.css' nodejs

Although the message is self-explanatory, but I was struggling a bit since I have had zero experience with Node.js. Finally I figured one need to install normalize.css simply:
npm install normalize.css

Maybe it is best that README to be updated.
And you are good to go, Happy labelling!!

@SkalskiP
Copy link
Owner

@mmortazavi For clarity, you're talking here about running locally on Windows 10 by the Ubuntu bash console?

Thanks a lot for the information, I admit that the whole application has been developed so far on Linux and Mac, and so far, on Windows 10, we were running only the online version.

@SkalskiP SkalskiP self-assigned this Aug 14, 2019
@SkalskiP SkalskiP added bug Something isn't working documentation Improvements or additions to documentation labels Aug 14, 2019
@mmortazavi
Copy link
Author

@mmortazavi For clarity, you're talking here about running locally on Windows 10 by the Ubuntu bash console?

Yes, exactly.

Thanks a lot for the information, I admit that the whole application has been developed so far on Linux and Mac, and so far, on Windows 10, we were running only the online version.

Noted. Thanks for sharing your work.

@SkalskiP
Copy link
Owner

@mmortazavi Great, I understand everything. In this situation, I will put an appropriate note in README.md. As I understand, simple npm install normalize.css --save is all you need to solve the problem?

@mmortazavi
Copy link
Author

Well, you know when you wanna make something work you try different things. The only step that was preceded before npm install normalize.css --save was to upgrade npm to the latest, whether it was relevant, I am not sure (your judgement, I found out about upgrading in another project repo):

npm install -g npm@latest

And restarted the system for changes to be effective, somewhere it was suggested!

@SkalskiP
Copy link
Owner

Sure, I've been in a situation like this more than once or twice. In my opinion npm install normalize.css --save addition should be enough. Once again, thank you very much for drawing attention to these problems!

@SkalskiP
Copy link
Owner

The information has been added to README.md in the develop version and will appear in the master with the next releas. It's visible in the section: Set Up the Project Locally.

@SkalskiP SkalskiP added this to Done in Make Sense Aug 15, 2019
@yyuuliang
Copy link

hi
can u give the local environmental setting? I installed npm and try to run, still have the same error
Cannot find module '@csstools/normalize.css'

@mmortazavi
Copy link
Author

Did you install npm install normalize.css --save as well?

@SkalskiP
Copy link
Owner

@yyuuliang In your case, does this problem occur on Windows or Linux?

My settings I work with:
OS: Linux Mint 19.1 Tessa
brawser: Chrome 72
npm: 6.7.0
node: v11.10.1

@nieszkodzi
Copy link

Hi! I have exactly the same issue on Ubuntu 18.04.3. I cloned repo, move to make-sense dir, than installed npm (by apt), then npm install and npm start the error occured:
Error: Cannot find module '@csstools/normalize.css'
then i tried npm install normalize.css --save
the error was still the same. Then npm install normalize.css npm install -g npm@latest npm install --save react-redux, npm install redux-devtools.

I have also one warning, no idea if it matters:
[email protected] requires a peer of react-redux@^4.0.0 || ^5.0.0 || ^6.0.0 but none was installed.

Anyone solved something like that?

@SkalskiP
Copy link
Owner

@nieszkodzi It seems that this error occurs more often than we suppose. We will try to fix the bug, but it is a problem because only a small percentage of users complain about it. In this situation, the issue is reopened, as the problem has not been solved.

In this situation I ask you to give me the exact version of npm and node you are using. @yyuuliang Could you also share the version numbers you are using?

@SkalskiP SkalskiP reopened this Sep 12, 2019
@nieszkodzi
Copy link

nieszkodzi commented Sep 12, 2019 via email

@SkalskiP
Copy link
Owner

@nieszkodzi! We conducted tests to try to recreate your environment and we also failed to run the application. Please update the node and npm versions. This should ensure the proper launch of the application. npm: 6.7.0, node: v11.10.1

@nieszkodzi
Copy link

Now I updated node to v12.10.0 and npm to 6.10.3, delete all repo, cloned it again, made all instructions one more time and it's working :)

@SkalskiP
Copy link
Owner

I'm very pleased to hear that! Then add to README the information that such versions are required to ensure proper local operation.

@SkalskiP
Copy link
Owner

I have added a new description to README, in this situation I am closing the issue again.

This was referenced Jun 22, 2023
This was referenced Jul 15, 2023
@github-actions github-actions bot mentioned this issue Aug 31, 2023
Closed
This was referenced Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
No open projects
Make Sense
  
Done
Development

No branches or pull requests

4 participants