Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserved Preferences (Settings Page) #202

Open
rasyidf opened this issue Sep 16, 2021 · 9 comments
Open

Preserved Preferences (Settings Page) #202

rasyidf opened this issue Sep 16, 2021 · 9 comments
Assignees
Labels
ms-beta Part of make-sense beta efforts new-feature New feature or request

Comments

@rasyidf
Copy link
Contributor

rasyidf commented Sep 16, 2021

Is your feature request related to a problem? Please describe.
It is always frustrating when we don't have global settings page / drawer / modal that can be used to preserve our preferences. moreover, with some customization that will be added in the future, (cursor color, layout?, defaults, language?, themes?) it needs some sort of settings ui

Describe the solution you'd like
we can agree that a dedicated settings page can be added (with capabilities of loading and saving data), and make it easier to reuse our preferences saved on LocalStorage.

Describe alternatives you've considered
If settings page isn't feasible in the meantime, we can add config file (as json) that can be import and exported by user.

@github-actions
Copy link

👋 Hello @rasyidf, thank you for your interest in make-sense - free to use online tool for labelling photos! 🏷️

🐞 Bug reports

If you noticed that make-sense is not working properly, please provide us with as much information as possible. To make your life easier, we have prepared a bug report template containing all the relevant details. We know, we ask for a lot... However, please believe that knowing all that extra information - like the type of browser you use or the version of node you have installed - really helps us to solve your problems faster and more efficiently. 😉

💬 Get in touch

If you've been trying to contact us but for some reason we haven't responded to your issue yet, don't hesitate to get back to us on Gitter or Twitter.

💻 Local setup

# clone repository
git clone https://github.com/SkalskiP/make-sense.git

# navigate to main dir
cd make-sense

# install dependencies
npm install

# serve with hot reload at localhost:3000
npm start

To ensure proper functionality of the application locally, an npm 6.x.x and node.js v12.x.x versions are required. More information about this problem is available in the #16 issue.

@SkalskiP
Copy link
Owner

Hi @rasyidf 👋 and once again thank you for your interest in makes-sense. It's very nice to know that we're already at that stage of the project that we should have a separate tab / popup with the settings. The thing that immediately comes to my mind is, setting the cursor color. A lot of users ask for this and I think it's a great opportunity to build the view you're talking about right away.

I will add this task to the scope of the make-sense beta project.

@SkalskiP SkalskiP self-assigned this Sep 16, 2021
@SkalskiP SkalskiP added ms-beta Part of make-sense beta efforts new-feature New feature or request labels Sep 16, 2021
@SkalskiP SkalskiP added this to To do in make-sense beta via automation Sep 16, 2021
@rasyidf
Copy link
Contributor Author

rasyidf commented Sep 17, 2021

thank you for your interest in makes-sense

I'm currently using makesense as our research tools, and I've been using it for a while, this is great project, and worth contributing. glad to be part of this community.

topics

yes, the cursor is sometimes off, especially on white image.

image

settings up default colors for labels, is also comes to my mind. what do you think about it?

@SkalskiP
Copy link
Owner

I've been using it for a while, this is great project, and worth contributing. glad to be part of this community.

Thank you so much for your kind words. I hope that this is not the end of the journey and with the help of creative people like you we can make some more noise. Regarding the cursor color, I am aware of this problem and will try to add this functionality in the near future.

@rasyidf what do you mean by settings up default colors for labels ?

@rasyidf
Copy link
Contributor Author

rasyidf commented Sep 21, 2021

@rasyidf what do you mean by settings up default colors for labels ?

   // /src/settings/Settings.ts
    public static readonly LABEL_COLORS_PALETTE = [
        '#ff3838',
       ...
        '#ff95c8',
        '#ff37c7'
    ]

I mean this. it would be great if we can specify label palette (I mean, it's not randomly picked).

@SkalskiP
Copy link
Owner

I was rather thinking that we could save that not in settings but in the saved project - #169. Label colors would be one of project metadata.

@rasyidf
Copy link
Contributor Author

rasyidf commented Sep 23, 2021

like I said before, it's just the default labels, so everytime users make project, they don't have to reapply their prefered labels.

@SkalskiP
Copy link
Owner

Hmm... you think people would like to have a default color palette?

@rasyidf
Copy link
Contributor Author

rasyidf commented Sep 24, 2021

well, thats just my assumption on how some apps even back from early desktop apps still using. look at windows command prompt, powershell, and even windows terminal, they shared same feature about default profile:
image

It's not necessarily important, but perhaps would be a good UX

Note : this will help only when make-sense is project based, and assume they're making projects occasionally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ms-beta Part of make-sense beta efforts new-feature New feature or request
Projects
Development

No branches or pull requests

2 participants