Move rollup to root package.json

[alex-page]

Co-Authored-By: Ben Scott [email protected]

Added a skip changelog as I don't think that consumers would be affected by this change.

[github-actions]

size-limit report 📦

Path	Size
cjs	153.26 KB (0%)
esm	89.64 KB (0%)
esnext	144.64 KB (0%)
css	41.54 KB (0%)

[BPScott]

Looking good. Happy to see this stuff be pulled up.

I see a few other rollup build related things that could be pulled up:

We should also pull up the dependencies on rollup (present in polaris-for-vscode, polaris-icons, polaris-tokens), @svgr/core (from polaris-icons), @shopify/browserslist-config (from polaris-tokens). Basically anything that gets mentioned from a rollup.config.js

We should also pull up and deduplicate the typescript dependency

[alex-page]

@BPScott @aaronccasanova what do you think about this? It is working locally.

[BPScott]

I think this is ok but is is pretty brittle. It relies upon eslint being ran in the specific package folders.

If you don't do that, e.g. running yarn eslint ./polaris-react in the root of the repo, causes thousands of errors for me. It also means I see errors in vscode, as that doesn't run with the cwd you're assuming. Sample:

/Users/ben/src/github.com/Shopify/polaris/polaris-react/tests/utilities/react-testing.tsx
0:1  error  The package.json file could not be found                                                                                  import/no-extraneous-dependencies
  1:1  error  'react' should be listed in the project's dependencies. Run 'npm i -S react' to add it                                    import/no-extraneous-dependencies
  2:1  error  '@shopify/react-testing' should be listed in the project's dependencies. Run 'npm i -S @shopify/react-testing' to add it  import/no-extraneous-dependencies

I suspect:

• These paths should be absolute so they don't depend upon the cwd
• We'd need to add overrides for each package to reference the correct package.json for each package.

[BPScott]

🎉