-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Pull Request body #65
Comments
Question is - how would you like to customize it? |
I should have explained my use-case 😄 We are using this for projects that are not npm-publishable packages (web & mobile apps). We really like the philosophy and process of creating changesets and want to use it without the need to publish it at the end. This is why I'd like to skip having the explanation of publishing in the PR body that might confuse someone who looks at the version update PR. My version update PR could have a body like this
Followed by the changelog of single/multiple packages. |
Hmm, I understand that the context of your project is a little bit different but even the PR body that you have given mentions something being published. Is this that big a problem that a publish process looks a little bit different than the one for npm? It's still there and I wouldn't think that the existing message would confuse anyone. Don't take me wrong - I'm not super opposed to allowing to configure it (although it would complicate a bunch of stuff), just bike-shedding a little bit before taking a final decision. |
@Andarist our team would love to add a checklist to the pull request before folks hit merge. To make sure that thorough testing has happened. Is this something that would want to warrant this change? Is the complication due to the release content reading from the merged PR content? Could this be decoupled into
|
Right now, the PR body is either
or
I was wondering if we can accept a
prBody
via VersionOptions like we acceptprTitle
. I wanted to understand if there was any specific reason, this customization was restricted to title only. I'd be happy to raise a PR with these changes if the maintainers think this would be a good addition.The text was updated successfully, but these errors were encountered: