YeePHP: added disconnect method and tests

src/Interfaces/YeePHPInterface.php

@@ -101,4 +101,11 @@ public function setPower(string $power): self;
      * @return bool
      */
     public function commit(): bool;
+
+    /**
+     * Close the opened socket. Return true if the socket has been closed
+     *
+     * @return bool
+     */
+    public function disconnect(): bool;
 }

src/YeePHP.php

@@ -85,7 +85,7 @@ public function __construct(string $ip, int $port = 55443)
      */
     public function __destruct()
     {
-        fclose($this->socket);
+        $this->disconnect();
     }
 
     /**
@@ -159,6 +159,8 @@ public function toggle(): self
      */
     public function setColor(int $hexColor): self
     {
+        // TODO: check if the color is a valid hexadecimal number
+
         $this->createJob('set_rgb', [
             $hexColor,
             $this->fadeEffect,
@@ -232,6 +234,19 @@ public function commit(): bool
         return $success;
     }
 
+    public function disconnect(): bool
+    {
+        try
+        {
+            return fclose($this->socket);
+        }
+        catch (\TypeError $e)
+        {
+            return false;
+        }
+
+    }
+
     protected function connect(): bool
     {
         $sock = fsockopen($this->lightIP, $this->lightPort, $errCode, $errStr, 3);
@@ -271,7 +286,7 @@ protected function getProp(string $prop): string
      */
     protected function checkIsOnline(): bool
     {
-        if(stream_get_meta_data($this->socket) === [])
+        if(socket_get_status($this->socket) === [])
             throw new Exception('Device is offline!');
 
         return true;

tests/LightTest.php

@@ -62,4 +62,15 @@ public function testCanGetLightProps()
         $this->assertNotEmpty($this->light->getBrightness());
         $this->assertNotEmpty($this->light->getColor());
     }
+
+    public function testIfDisconnectMethodReturnTrueIfTheSocketHasBeenClosed()
+    {
+        $this->assertTrue($this->light->disconnect());
+    }
+
+    public function testIfDisconnectMethodReturnFalseIfTheSocketHasBeenAlreadyClosed()
+    {
+        $this->light->disconnect();
+        $this->assertFalse($this->light->disconnect());
+    }
 }