YeePHP: refactor checkIsOnline() method

With feof, it used to return false negative, switched to stream_get_meta_data() function instead

src/YeePHP.php

@@ -234,7 +234,7 @@ public function commit(): bool
 
     protected function connect(): bool
     {
-        $sock = fsockopen($this->lightIP, $this->lightPort, $errCode, $errStr, 5);
+        $sock = fsockopen($this->lightIP, $this->lightPort, $errCode, $errStr, 3);
         if(!$sock) return false;
 
         stream_set_blocking($sock, false);
@@ -271,7 +271,7 @@ protected function getProp(string $prop): string
      */
     protected function checkIsOnline(): bool
     {
-        if(feof($this->socket))
+        if(stream_get_meta_data($this->socket) === [])
             throw new Exception('Device is offline!');
 
         return true;
@@ -286,8 +286,6 @@ protected function checkIsOnline(): bool
      */
     protected function makeRequest(array $job): ?string
     {
-        $success = false;
-
         $this->checkIsOnline();
 
         $requestStr = json_encode($job) . "\r\n";

tests/LightTest.php

@@ -23,6 +23,12 @@ protected function setUp(): void
         $this->light = new YeePHP($this->ip);
     }
 
+    public function testConstructorThrowExceptionIfTheIpAdressIsInvalid()
+    {
+        $this->expectException(\Exception::class);
+        new YeePHP('192.1555.0.0');
+    }
+
     public function testCanSeeIfLightIsOnline(): void
     {
         $this->assertTrue($this->light->isConnected());
@@ -42,12 +48,12 @@ public function testLightCanChangeBrightness(): void
 
     public function testLightCanChangeColorAndBrightness(): void
     {
-        $this->assertTrue(
-            $this->light
+        $res = $this->light
             ->setColor(0xFF8888)
             ->setBrightness(100)
-            ->commit()
-        );
+            ->commit();
+
+        $this->assertTrue($res);
     }
 
     public function testCanGetLightProps()