Refactor the decl scope loop to consolidate modifier handling. (carbo…

…n-language#3463)

Building on carbon-language#3462, trying to make the flow easier to see, also making a
little more use of macros for boilerplate modifier handling.

---------

Co-authored-by: josh11b <[email protected]>
Co-authored-by: Richard Smith <[email protected]>