Refactor the decl scope loop to consolidate modifier handling. #3463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
86a3927
to
2d8d266
Compare
Specifically using these abbreviations: * InitRepr: "initializing representation" * ObjectRepr: "object representation" * ValueRepr: "value representation" As discussed in [#toolchain discord](https://discord.com/channels/655572317891461132/655578254970716160/1182086098470572143) and now documented in the [list of abbreviations](https://docs.google.com/document/d/1RRYMm42osyqhI2LyjrjockYCutQ5dOf8Abu50kTrkX0/edit?resourcekey=0-kHyqOESbOHmzZphUbtLrTw#heading=h.pph7i5m5un7q).
2d8d266
to
b2fb136
Compare
zygoloid
reviewed
Dec 6, 2023
Per their documentation, the `llvm::Initialize*` functions are only supposed to be called by the main program, not by a library like toolchain/codegen. Fixes a hang due to a data race in multithreaded autoupdate. Add a utility class `Carbon::InitLLVM` to do the common LLVM initialization shared by all Carbon tools, optionally including initializing the LLVM targets. Because the LLVM targets add a lot of binary size, only initialize them for binaries that opt in by depending on a new target `//common:all_llvm_targets`. Also fix `//explorer:file_test` and `//explorer:file_test.trace` to share a binary rather than linking an identical binary twice. --------- Co-authored-by: Jon Ross-Perkins <[email protected]>
…nds of parse nodes that represent names. (carbon-language#3453) Factor out common checking handling for the different kinds of unqualified names
…ack to an error type if that fails. (carbon-language#3454) As requested in [review of carbon-language#3450](carbon-language#3450 (comment)).
…arbon-language#3468) The criteria being enforced is not correct since `final` and `default` functions in interfaces have definitions.
zygoloid
approved these changes
Dec 8, 2023
Comment on lines
83
to
89
| // `base` may be followed by: | ||
| // - a colon | ||
| // => assume it is an introducer, as in `extend base: BaseType;`. | ||
| // - a modifier or an introducer | ||
| // => assume it is a modifier, as in `base class`; which is handled | ||
| // by falling through to the next case. | ||
| // Anything else is an error. |
There was a problem hiding this comment.
I think this comment is out of date (at least the modifier part and "falling through")
There was a problem hiding this comment.
Cleaning up the comment.
Co-authored-by: Richard Smith <[email protected]>
|
Thanks, I'd totally overlooked the ability to shift the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on #3462, trying to make the flow easier to see, also making a little more use of macros for boilerplate modifier handling.