Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibWasm: Some more performance stuff #8812

Merged
merged 4 commits into from
Jul 16, 2021
Merged

LibWasm: Some more performance stuff #8812

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ad0a15
wasm: Don't try to print the function results if it traps
alimpfard Jul 12, 2021
1a84df0
LibWasm: Inline some very hot functions
alimpfard Jul 12, 2021
0b1bedc
LibWasm+Everywhere: Make the instruction count limit configurable
alimpfard Jul 14, 2021
e026629
LibWasm: Remove a useless use of ScopeGuard
alimpfard Jul 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
LibWasm: Remove a useless use of ScopeGuard 
There are no multiple exit paths in that function, so we can just put
the ending logic right at the end of the function instead.
  • Loading branch information
@alimpfard
alimpfard committed Jul 16, 2021
commit e02662988bbb5d51a683671098389efb3712dc90
18 changes: 8 additions & 10 deletions Userland/Libraries/LibWasm/AbstractMachine/BytecodeInterpreter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1126,17 +1126,15 @@ void DebuggerBytecodeInterpreter::interpret(Configuration& configuration, Instru
}
}

ScopeGuard guard { [&] {
if (post_interpret_hook) {
auto result = post_interpret_hook(configuration, ip, instruction, *this);
if (!result) {
m_trap = Trap { "Trapped by user request" };
return;
}
}
} };

BytecodeInterpreter::interpret(configuration, ip, instruction);

if (post_interpret_hook) {
auto result = post_interpret_hook(configuration, ip, instruction, *this);
if (!result) {
m_trap = Trap { "Trapped by user request" };
return;
}
}
}

}