LibWasm: Some more performance stuff #8812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are mostly pretty small functions too, and they were about ~10% of runtime.
...and enable it for LibWeb and test-wasm. Note that `wasm` will not be limited by this.
There are no multiple exit paths in that function, so we can just put the ending logic right at the end of the function instead.
alimpfard
added a commit
that referenced
this pull request
Jul 16, 2021
This reverts commit 35394db. I pushed the wrong button again, hopefully this will be the last of such incidents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had these strewn about in multiple branches, figured I'd just put them here.
This is overall about a ~20% increase in performance when using
wasm, and about a ~10% increase in performance when using the browser.