WindowServer: More natural mouse menu navigation #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awesomekling
requested changes
Jan 18, 2020
shannonbooth
force-pushed
the
natural-menu
branch
from
11423ba
to
217176a
Compare
shannonbooth
force-pushed
the
natural-menu
branch
from
217176a
to
1974854
Compare
xTibor
reviewed
Jan 19, 2020
gootik
reviewed
Jan 19, 2020
shannonbooth
force-pushed
the
natural-menu
branch
from
1974854
to
bfad0c5
Compare
awesomekling
requested changes
Jan 19, 2020
Currently the points of a triangle do not need to be initialised in a certain orientation. Currently, the only real method in the class is `contains`. However we can continue extending the class if and when we need more functionality.
Use an imaginary triangle between the top and bottom of the submenu of a hovered item to determine whether the mouse is moving towards the submenu. If it is, we do not update the hovered item. This allows the submenu to stay open, making for much easier menu navigation. Closes SerenityOS#1094
shannonbooth
force-pushed
the
natural-menu
branch
from
bfad0c5
to
9ed34a5
Compare
|
Nw, looks cool! Thanks for implementing this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use an imaginary triangle between the top and bottom of the submenu of a
hovered item to determine whether the mouse is moving towards the
submenu. If it is, we do not update the hovered item. This allows the
submenu to stay open, making for much easier menu navigation.
Also add the beginnings of a triangle class which is used to help implement
this feature.
Closes #1094