Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster concatenation of cubes with AuxCoordFactorys #6038

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Faster concatenation of cubes with AuxCoordFactorys #6038

merged 3 commits into from
Jul 9, 2024

Conversation

bouweandela
Copy link
Member

🚀 Pull Request

Description

Consult Iris pull request check list

Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

@bouweandela bouweandela force-pushed the faster-concatenate-aux-factory branch from 1b63e40 to 53c300d Compare July 3, 2024 06:31
@codecov Codecov
Copy link

codecov bot commented Jul 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.77%. Comparing base (1115fa4) to head (37d2d42).
Report is 59 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6038   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files          90       90           
  Lines       22984    22984           
  Branches     5031     5031           
=======================================
  Hits        20634    20634           
  Misses       1619     1619           
  Partials      731      731

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bouweandela bouweandela added the benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts label Jul 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024

⏱️ Performance Benchmark Report: 8635ff8

Performance shifts
Full benchmark results 

Benchmarks that have stayed the same:

| Change   | Before [d0801aaa]    | After [8635ff8b]    | Ratio   | Benchmark (Parameter)                                                                                  |
|----------|----------------------|---------------------|---------|--------------------------------------------------------------------------------------------------------|
|          | 53.6±0.5ms           | 53.6±0.7ms          | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_COUNT(False)                                         |
|          | 53.5±0.8ms           | 53.7±0.5ms          | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_COUNT(True)                                          |
|          | 188±1ms              | 188±3ms             | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_FAST_PERCENTILE(False)                               |
|          | 189±1ms              | 190±2ms             | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_FAST_PERCENTILE(True)                                |
|          | 36.5±0.4ms           | 36.4±0.3ms          | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_GMEAN(False)                                         |
|          | 37.4±0.4ms           | 37.0±0.3ms          | 0.99    | aggregate_collapse.Aggregation.time_aggregated_by_GMEAN(True)                                          |
|          | 36.8±0.6ms           | 36.5±0.5ms          | 0.99    | aggregate_collapse.Aggregation.time_aggregated_by_HMEAN(False)                                         |
|          | 37.6±0.4ms           | 37.1±0.5ms          | 0.99    | aggregate_collapse.Aggregation.time_aggregated_by_HMEAN(True)                                          |
|          | 46.7±0.4ms           | 46.5±0.4ms          | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_MAX(False)                                           |
|          | 47.1±0.5ms           | 47.3±0.6ms          | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_MAX(True)                                            |
|          | 121±0.9ms            | 120±1ms             | 0.99    | aggregate_collapse.Aggregation.time_aggregated_by_MAX_RUN(False)                                       |
|          | 121±1ms              | 121±1ms             | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_MAX_RUN(True)                                        |
|          | 51.1±0.6ms           | 51.2±0.5ms          | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_MEAN(False)                                          |
|          | 51.7±0.4ms           | 51.7±0.6ms          | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_MEAN(True)                                           |
|          | 36.1±0.5ms           | 36.7±0.4ms          | 1.02    | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(False)                                        |
|          | 37.2±0.6ms           | 37.5±0.5ms          | 1.01    | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(True)                                         |
|          | 46.3±0.7ms           | 46.6±0.6ms          | 1.01    | aggregate_collapse.Aggregation.time_aggregated_by_MIN(False)                                           |
|          | 47.2±0.6ms           | 47.1±0.7ms          | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_MIN(True)                                            |
|          | 1.32±0.02s           | 1.30±0.02s          | 0.98    | aggregate_collapse.Aggregation.time_aggregated_by_PEAK(False)                                          |
|          | 1.32±0.01s           | 1.32±0.01s          | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_PEAK(True)                                           |
|          | 675±10ms             | 661±10ms            | 0.98    | aggregate_collapse.Aggregation.time_aggregated_by_PERCENTILE(False)                                    |
|          | 683±10ms             | 672±10ms            | 0.98    | aggregate_collapse.Aggregation.time_aggregated_by_PERCENTILE(True)                                     |
|          | 34.8±0.6ms           | 34.9±0.3ms          | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_PROPORTION(False)                                    |
|          | 35.7±0.4ms           | 35.5±0.5ms          | 0.99    | aggregate_collapse.Aggregation.time_aggregated_by_PROPORTION(True)                                     |
|          | 61.7±0.3ms           | 62.7±0.5ms          | 1.02    | aggregate_collapse.Aggregation.time_aggregated_by_RMS(False)                                           |
|          | 62.2±0.6ms           | 62.8±0.6ms          | 1.01    | aggregate_collapse.Aggregation.time_aggregated_by_RMS(True)                                            |
|          | 65.9±0.6ms           | 66.3±1ms            | 1.01    | aggregate_collapse.Aggregation.time_aggregated_by_STD_DEV(False)                                       |
|          | 66.4±0.8ms           | 66.5±0.5ms          | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_STD_DEV(True)                                        |
|          | 60.7±0.6ms           | 60.8±0.5ms          | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_VARIANCE(False)                                      |
|          | 61.8±0.5ms           | 61.8±0.6ms          | 1.00    | aggregate_collapse.Aggregation.time_aggregated_by_VARIANCE(True)                                       |
|          | 19.5±0.7ms           | 19.6±0.5ms          | 1.01    | aggregate_collapse.Aggregation.time_collapsed_by_COUNT(False)                                          |
|          | 23.5±0.3ms           | 23.2±0.4ms          | 0.99    | aggregate_collapse.Aggregation.time_collapsed_by_COUNT(True)                                           |
|          | 130±1ms              | 130±1ms             | 1.00    | aggregate_collapse.Aggregation.time_collapsed_by_FAST_PERCENTILE(False)                                |
|          | 144±0.7ms            | 144±1ms             | 1.00    | aggregate_collapse.Aggregation.time_collapsed_by_FAST_PERCENTILE(True)                                 |
|          | 17.8±0.3ms           | 18.0±0.3ms          | 1.01    | aggregate_collapse.Aggregation.time_collapsed_by_GMEAN(False)                                          |
|          | 21.5±0.2ms           | 21.8±0.5ms          | 1.01    | aggregate_collapse.Aggregation.time_collapsed_by_GMEAN(True)                                           |
|          | 17.8±0.3ms           | 17.9±0.2ms          | 1.00    | aggregate_collapse.Aggregation.time_collapsed_by_HMEAN(False)                                          |
|          | 21.6±0.3ms           | 21.7±0.4ms          | 1.00    | aggregate_collapse.Aggregation.time_collapsed_by_HMEAN(True)                                           |
|          | 18.6±0.3ms           | 18.5±0.2ms          | 0.99    | aggregate_collapse.Aggregation.time_collapsed_by_MAX(False)                                            |
|          | 22.8±0.6ms           | 22.1±0.4ms          | 0.97    | aggregate_collapse.Aggregation.time_collapsed_by_MAX(True)                                             |
|          | 34.6±0.7ms           | 34.2±0.5ms          | 0.99    | aggregate_collapse.Aggregation.time_collapsed_by_MAX_RUN(False)                                        |
|          | 38.0±1ms             | 37.7±1ms            | 0.99    | aggregate_collapse.Aggregation.time_collapsed_by_MAX_RUN(True)                                         |
|          | 18.7±0.5ms           | 19.0±0.5ms          | 1.01    | aggregate_collapse.Aggregation.time_collapsed_by_MEAN(False)                                           |
|          | 22.5±0.3ms           | 22.5±0.3ms          | 1.00    | aggregate_collapse.Aggregation.time_collapsed_by_MEAN(True)                                            |
|          | 18.6±0.3ms           | 18.6±0.4ms          | 1.00    | aggregate_collapse.Aggregation.time_collapsed_by_MEDIAN(False)                                         |
|          | 22.2±0.3ms           | 22.2±0.7ms          | 1.00    | aggregate_collapse.Aggregation.time_collapsed_by_MEDIAN(True)                                          |
|          | 18.7±0.4ms           | 18.4±0.2ms          | 0.99    | aggregate_collapse.Aggregation.time_collapsed_by_MIN(False)                                            |
|          | 22.0±0.3ms           | 22.5±0.6ms          | 1.02    | aggregate_collapse.Aggregation.time_collapsed_by_MIN(True)                                             |
|          | 556±5ms              | 548±2ms             | 0.98    | aggregate_collapse.Aggregation.time_collapsed_by_PEAK(False)                                           |
|          | 556±3ms              | 562±8ms             | 1.01    | aggregate_collapse.Aggregation.time_collapsed_by_PEAK(True)                                            |
|          | 148±1ms              | 149±3ms             | 1.01    | aggregate_collapse.Aggregation.time_collapsed_by_PERCENTILE(False)                                     |
|          | 167±1ms              | 167±1ms             | 1.00    | aggregate_collapse.Aggregation.time_collapsed_by_PERCENTILE(True)                                      |
|          | 17.6±0.3ms           | 17.8±0.4ms          | 1.01    | aggregate_collapse.Aggregation.time_collapsed_by_PROPORTION(False)                                     |
|          | 21.5±0.4ms           | 21.9±0.6ms          | 1.02    | aggregate_collapse.Aggregation.time_collapsed_by_PROPORTION(True)                                      |
|          | 20.9±0.3ms           | 21.1±0.8ms          | 1.01    | aggregate_collapse.Aggregation.time_collapsed_by_RMS(False)                                            |
|          | 24.7±0.6ms           | 24.8±0.09ms         | 1.00    | aggregate_collapse.Aggregation.time_collapsed_by_RMS(True)                                             |
|          | 21.0±0.3ms           | 21.0±0.3ms          | 1.00    | aggregate_collapse.Aggregation.time_collapsed_by_STD_DEV(False)                                        |
|          | 24.9±0.4ms           | 24.7±0.4ms          | 0.99    | aggregate_collapse.Aggregation.time_collapsed_by_STD_DEV(True)                                         |
|          | 20.2±0.2ms           | 20.6±0.8ms          | 1.02    | aggregate_collapse.Aggregation.time_collapsed_by_VARIANCE(False)                                       |
|          | 23.9±0.6ms           | 24.2±0.7ms          | 1.02    | aggregate_collapse.Aggregation.time_collapsed_by_VARIANCE(True)                                        |
|          | 82.7±1ms             | 82.9±1ms            | 1.00    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_MEAN(False)                                |
|          | 83.5±0.9ms           | 83.3±0.5ms          | 1.00    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_MEAN(True)                                 |
|          | 94.7±1ms             | 96.2±1ms            | 1.02    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_RMS(False)                                 |
|          | 94.7±0.4ms           | 95.5±1ms            | 1.01    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_RMS(True)                                  |
|          | 57.5±0.7ms           | 57.8±0.9ms          | 1.01    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_SUM(False)                                 |
|          | 58.4±0.8ms           | 58.7±0.9ms          | 1.01    | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_SUM(True)                                  |
|          | 28.7±0.6ms           | 28.7±0.6ms          | 1.00    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_MEAN(False)                                 |
|          | 32.6±0.4ms           | 32.5±0.6ms          | 1.00    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_MEAN(True)                                  |
|          | 31.0±0.4ms           | 30.8±0.4ms          | 0.99    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_RMS(False)                                  |
|          | 35.0±0.4ms           | 34.9±0.8ms          | 1.00    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_RMS(True)                                   |
|          | 25.5±0.2ms           | 25.6±0.4ms          | 1.00    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_SUM(False)                                  |
|          | 29.0±0.4ms           | 29.3±0.2ms          | 1.01    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_SUM(True)                                   |
|          | 323±4ms              | 323±4ms             | 1.00    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_WPERCENTILE(False)                          |
|          | 343±3ms              | 346±4ms             | 1.01    | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_WPERCENTILE(True)                           |
|          | 1.12±0.01ms          | 1.12±0.02ms         | 1.00    | cube.CubeCreation.time_create(False, 'construct')                                                      |
|          | 401±3μs              | 396±6μs             | 0.99    | cube.CubeCreation.time_create(False, 'instantiate')                                                    |
|          | 949±9μs              | 955±20μs            | 1.01    | cube.CubeCreation.time_create(True, 'construct')                                                       |
|          | 575±10μs             | 578±8μs             | 1.01    | cube.CubeCreation.time_create(True, 'instantiate')                                                     |
|          | 221±2ms              | 224±4ms             | 1.01    | cube.CubeEquality.time_equality(False, False, 'all_equal')                                             |
|          | 112±1ms              | 112±2ms             | 1.00    | cube.CubeEquality.time_equality(False, False, 'coord_inequality')                                      |
|          | 232±4ms              | 235±3ms             | 1.01    | cube.CubeEquality.time_equality(False, False, 'data_inequality')                                       |
|          | 16.4±0.1μs           | 16.7±0.2μs          | 1.02    | cube.CubeEquality.time_equality(False, False, 'metadata_inequality')                                   |
|          | 305±3ms              | 308±5ms             | 1.01    | cube.CubeEquality.time_equality(False, True, 'all_equal')                                              |
|          | 199±2ms              | 200±3ms             | 1.01    | cube.CubeEquality.time_equality(False, True, 'coord_inequality')                                       |
|          | 316±2ms              | 317±3ms             | 1.00    | cube.CubeEquality.time_equality(False, True, 'data_inequality')                                        |
|          | 16.7±0.2μs           | 16.7±0.1μs          | 1.00    | cube.CubeEquality.time_equality(False, True, 'metadata_inequality')                                    |
|          | 220±3ms              | 220±3ms             | 1.00    | cube.CubeEquality.time_equality(True, False, 'all_equal')                                              |
|          | 112±1ms              | 114±3ms             | 1.02    | cube.CubeEquality.time_equality(True, False, 'coord_inequality')                                       |
|          | 232±2ms              | 232±3ms             | 1.00    | cube.CubeEquality.time_equality(True, False, 'data_inequality')                                        |
|          | 53.3±0.5μs           | 53.5±0.6μs          | 1.01    | cube.CubeEquality.time_equality(True, False, 'metadata_inequality')                                    |
|          | 307±2ms              | 305±4ms             | 0.99    | cube.CubeEquality.time_equality(True, True, 'all_equal')                                               |
|          | 198±1ms              | 199±2ms             | 1.00    | cube.CubeEquality.time_equality(True, True, 'coord_inequality')                                        |
|          | 318±2ms              | 317±2ms             | 0.99    | cube.CubeEquality.time_equality(True, True, 'data_inequality')                                         |
|          | 54.4±0.8μs           | 54.6±0.4μs          | 1.00    | cube.CubeEquality.time_equality(True, True, 'metadata_inequality')                                     |
|          | 422±3ns              | 415±2ns             | 0.98    | experimental.ugrid.regions_combine.CombineRegionsComputeRealData.time_compute_data(50)                 |
|          | 279±2ms              | 278±2ms             | 1.00    | experimental.ugrid.regions_combine.CombineRegionsComputeRealData.time_compute_data(500)                |
|          | 0.6                  | 0.6                 | 1.00    | experimental.ugrid.regions_combine.CombineRegionsComputeRealData.track_addedmem_compute_data(50)       |
|          | 57.3                 | 57.3                | 1.00    | experimental.ugrid.regions_combine.CombineRegionsComputeRealData.track_addedmem_compute_data(500)      |
|          | 14.4±0.09ms          | 14.2±0.2ms          | 0.99    | experimental.ugrid.regions_combine.CombineRegionsCreateCube.time_create_combined_cube(50)              |
|          | 16.0±0.4ms           | 16.1±0.4ms          | 1.00    | experimental.ugrid.regions_combine.CombineRegionsCreateCube.time_create_combined_cube(500)             |
|          | 0.5                  | 0.5                 | 1.00    | experimental.ugrid.regions_combine.CombineRegionsCreateCube.track_addedmem_create_combined_cube(50)    |
|          | 11.8                 | 11.8                | 1.00    | experimental.ugrid.regions_combine.CombineRegionsCreateCube.track_addedmem_create_combined_cube(500)   |
|          | 105±1ms              | 105±1ms             | 1.00    | experimental.ugrid.regions_combine.CombineRegionsFileStreamedCalc.time_stream_file2file(50)            |
|          | 721±3ms              | 723±4ms             | 1.00    | experimental.ugrid.regions_combine.CombineRegionsFileStreamedCalc.time_stream_file2file(500)           |
|          | 1.4                  | 1.4                 | 1.00    | experimental.ugrid.regions_combine.CombineRegionsFileStreamedCalc.track_addedmem_stream_file2file(50)  |
|          | 92.0                 | 92.0                | 1.00    | experimental.ugrid.regions_combine.CombineRegionsFileStreamedCalc.track_addedmem_stream_file2file(500) |
|          | 65.6±0.5ms           | 66.0±0.3ms          | 1.01    | experimental.ugrid.regions_combine.CombineRegionsSaveData.time_save(50)                                |
|          | 672±3ms              | 673±4ms             | 1.00    | experimental.ugrid.regions_combine.CombineRegionsSaveData.time_save(500)                               |
|          | 1.3                  | 1.3                 | 1.00    | experimental.ugrid.regions_combine.CombineRegionsSaveData.track_addedmem_save(50)                      |
|          | 92.0                 | 91.9                | 1.00    | experimental.ugrid.regions_combine.CombineRegionsSaveData.track_addedmem_save(500)                     |
|          | 2.1752849999999997   | 2.1752849999999997  | 1.00    | experimental.ugrid.regions_combine.CombineRegionsSaveData.track_filesize_saved(50)                     |
|          | 216.01528499999998   | 216.01528499999998  | 1.00    | experimental.ugrid.regions_combine.CombineRegionsSaveData.track_filesize_saved(500)                    |
|          | 656±7μs              | 659±6μs             | 1.00    | import_iris.Iris.time__concatenate                                                                     |
|          | 180±2μs              | 182±2μs             | 1.01    | import_iris.Iris.time__constraints                                                                     |
|          | 110±1μs              | 110±0.7μs           | 1.00    | import_iris.Iris.time__data_manager                                                                    |
|          | 93.5±0.6μs           | 93.7±0.3μs          | 1.00    | import_iris.Iris.time__deprecation                                                                     |
|          | 136±0.7μs            | 137±0.8μs           | 1.00    | import_iris.Iris.time__lazy_data                                                                       |
|          | 891±4μs              | 901±10μs            | 1.01    | import_iris.Iris.time__merge                                                                           |
|          | 76.3±0.3μs           | 76.4±0.3μs          | 1.00    | import_iris.Iris.time__representation                                                                  |
|          | 478±7μs              | 490±10μs            | 1.02    | import_iris.Iris.time_analysis                                                                         |
|          | 139±0.9μs            | 141±3μs             | 1.01    | import_iris.Iris.time_analysis__area_weighted                                                          |
|          | 109±1μs              | 110±1μs             | 1.00    | import_iris.Iris.time_analysis__grid_angles                                                            |
|          | 240±2μs              | 240±3μs             | 1.00    | import_iris.Iris.time_analysis__interpolation                                                          |
|          | 187±2μs              | 185±2μs             | 0.99    | import_iris.Iris.time_analysis__regrid                                                                 |
|          | 110±0.9μs            | 111±1μs             | 1.01    | import_iris.Iris.time_analysis__scipy_interpolate                                                      |
|          | 140±0.8μs            | 139±2μs             | 0.99    | import_iris.Iris.time_analysis_calculus                                                                |
|          | 328±2μs              | 325±2μs             | 0.99    | import_iris.Iris.time_analysis_cartography                                                             |
|          | 92.9±0.4μs           | 94.4±0.4μs          | 1.02    | import_iris.Iris.time_analysis_geomerty                                                                |
|          | 217±2μs              | 218±2μs             | 1.01    | import_iris.Iris.time_analysis_maths                                                                   |
|          | 97.5±0.5μs           | 98.3±2μs            | 1.01    | import_iris.Iris.time_analysis_stats                                                                   |
|          | 176±3μs              | 175±3μs             | 1.00    | import_iris.Iris.time_analysis_trajectory                                                              |
|          | 305±4μs              | 304±7μs             | 1.00    | import_iris.Iris.time_aux_factory                                                                      |
|          | 84.7±0.7μs           | 84.3±0.4μs          | 1.00    | import_iris.Iris.time_common                                                                           |
|          | 162±4μs              | 163±4μs             | 1.01    | import_iris.Iris.time_common_lenient                                                                   |
|          | 976±4μs              | 988±8μs             | 1.01    | import_iris.Iris.time_common_metadata                                                                  |
|          | 132±1μs              | 134±1μs             | 1.01    | import_iris.Iris.time_common_mixin                                                                     |
|          | 1.18±0.01ms          | 1.20±0.01ms         | 1.02    | import_iris.Iris.time_common_resolve                                                                   |
|          | 200±1μs              | 199±2μs             | 1.00    | import_iris.Iris.time_config                                                                           |
|          | 116±2μs              | 117±2μs             | 1.00    | import_iris.Iris.time_coord_categorisation                                                             |
|          | 358±3μs              | 360±6μs             | 1.00    | import_iris.Iris.time_coord_systems                                                                    |
|          | 736±10μs             | 738±6μs             | 1.00    | import_iris.Iris.time_coords                                                                           |
|          | 662±8μs              | 661±9μs             | 1.00    | import_iris.Iris.time_cube                                                                             |
|          | 222±3μs              | 227±3μs             | 1.02    | import_iris.Iris.time_exceptions                                                                       |
|          | 77.4±0.9μs           | 77.5±0.9μs          | 1.00    | import_iris.Iris.time_experimental                                                                     |
|          | 188±1μs              | 188±3μs             | 1.00    | import_iris.Iris.time_fileformats                                                                      |
|          | 250±3μs              | 250±4μs             | 1.00    | import_iris.Iris.time_fileformats__ff                                                                  |
|          | 2.67±0.02ms          | 2.69±0.04ms         | 1.01    | import_iris.Iris.time_fileformats__ff_cross_references                                                 |
|          | 79.3±0.6μs           | 79.6±2μs            | 1.00    | import_iris.Iris.time_fileformats__pp_lbproc_pairs                                                     |
|          | 115±1μs              | 115±1μs             | 1.00    | import_iris.Iris.time_fileformats_abf                                                                  |
|          | 360±2μs              | 359±2μs             | 1.00    | import_iris.Iris.time_fileformats_cf                                                                   |
|          | 5.31±0.04ms          | 5.33±0.05ms         | 1.01    | import_iris.Iris.time_fileformats_dot                                                                  |
|          | 74.6±0.5μs           | 74.6±0.5μs          | 1.00    | import_iris.Iris.time_fileformats_name                                                                 |
|          | 257±1μs              | 257±2μs             | 1.00    | import_iris.Iris.time_fileformats_name_loaders                                                         |
|          | 119±1μs              | 117±1μs             | 0.99    | import_iris.Iris.time_fileformats_netcdf                                                               |
|          | 122±0.4μs            | 122±1μs             | 1.00    | import_iris.Iris.time_fileformats_nimrod                                                               |
|          | 214±3μs              | 214±4μs             | 1.00    | import_iris.Iris.time_fileformats_nimrod_load_rules                                                    |
|          | 780±7μs              | 781±7μs             | 1.00    | import_iris.Iris.time_fileformats_pp                                                                   |
|          | 182±3μs              | 183±3μs             | 1.01    | import_iris.Iris.time_fileformats_pp_load_rules                                                        |
|          | 135±2μs              | 134±2μs             | 1.00    | import_iris.Iris.time_fileformats_pp_save_rules                                                        |
|          | 513±4μs              | 512±5μs             | 1.00    | import_iris.Iris.time_fileformats_rules                                                                |
|          | 222±3μs              | 218±1μs             | 0.98    | import_iris.Iris.time_fileformats_structured_array_identification                                      |
|          | 83.2±0.5μs           | 83.5±0.2μs          | 1.00    | import_iris.Iris.time_fileformats_um                                                                   |
|          | 165±2μs              | 161±2μs             | 0.97    | import_iris.Iris.time_fileformats_um__fast_load                                                        |
|          | 138±0.9μs            | 139±0.9μs           | 1.01    | import_iris.Iris.time_fileformats_um__fast_load_structured_fields                                      |
|          | 75.7±0.4μs           | 76.1±0.7μs          | 1.01    | import_iris.Iris.time_fileformats_um__ff_replacement                                                   |
|          | 81.9±0.6μs           | 81.5±0.3μs          | 1.00    | import_iris.Iris.time_fileformats_um__optimal_array_structuring                                        |
|          | 970±9μs              | 973±20μs            | 1.00    | import_iris.Iris.time_fileformats_um_cf_map                                                            |
|          | 136±0.8μs            | 138±0.9μs           | 1.01    | import_iris.Iris.time_io                                                                               |
|          | 174±2μs              | 172±2μs             | 0.99    | import_iris.Iris.time_io_format_picker                                                                 |
|          | 230±4μs              | 238±8μs             | 1.03    | import_iris.Iris.time_iris                                                                             |
|          | 127±0.4μs            | 128±2μs             | 1.01    | import_iris.Iris.time_iterate                                                                          |
|          | 8.45±0.08ms          | 8.41±0.07ms         | 0.99    | import_iris.Iris.time_palette                                                                          |
|          | 2.24±0.05ms          | 2.21±0.04ms         | 0.99    | import_iris.Iris.time_plot                                                                             |
|          | 104±0.5μs            | 104±1μs             | 1.00    | import_iris.Iris.time_quickplot                                                                        |
|          | 2.14±0.03ms          | 2.15±0.04ms         | 1.01    | import_iris.Iris.time_std_names                                                                        |
|          | 1.77±0.01ms          | 1.77±0.01ms         | 1.00    | import_iris.Iris.time_symbols                                                                          |
|          | 35.5±1ms             | 36.0±1ms            | 1.01    | import_iris.Iris.time_tests                                                                            |
|          | 257±2μs              | 256±2μs             | 1.00    | import_iris.Iris.time_third_party_cartopy                                                              |
|          | 4.80±0.04ms          | 4.80±0.03ms         | 1.00    | import_iris.Iris.time_third_party_cf_units                                                             |
|          | 119±0.8μs            | 118±0.4μs           | 1.00    | import_iris.Iris.time_third_party_cftime                                                               |
|          | 2.79±0.01ms          | 2.80±0.03ms         | 1.00    | import_iris.Iris.time_third_party_matplotlib                                                           |
|          | 1.07±0ms             | 1.07±0.01ms         | 1.00    | import_iris.Iris.time_third_party_numpy                                                                |
|          | 170±0.7μs            | 170±1μs             | 1.00    | import_iris.Iris.time_third_party_scipy                                                                |
|          | 99.8±2μs             | 99.8±0.6μs          | 1.00    | import_iris.Iris.time_time                                                                             |
|          | 320±3μs              | 323±3μs             | 1.01    | import_iris.Iris.time_util                                                                             |
|          | 74.2±0.9μs           | 73.6±0.8μs          | 0.99    | iterate.IZip.time_izip                                                                                 |
|          | 8.10±0.03ms          | 8.06±0.05ms         | 0.99    | load.LoadAndRealise.time_load((1280, 960, 5), False, 'FF')                                             |
|          | 23.6±0.3ms           | 23.6±0.5ms          | 1.00    | load.LoadAndRealise.time_load((1280, 960, 5), False, 'NetCDF')                                         |
|          | 8.86±0.03ms          | 8.83±0.07ms         | 1.00    | load.LoadAndRealise.time_load((1280, 960, 5), False, 'PP')                                             |
|          | 8.13±0.04ms          | 8.01±0.2ms          | 0.99    | load.LoadAndRealise.time_load((1280, 960, 5), True, 'FF')                                              |
|          | 21.0±0.1ms           | 21.1±0.2ms          | 1.00    | load.LoadAndRealise.time_load((1280, 960, 5), True, 'NetCDF')                                          |
|          | 8.88±0.03ms          | 8.79±0.08ms         | 0.99    | load.LoadAndRealise.time_load((1280, 960, 5), True, 'PP')                                              |
|          | 1.36±0.01s           | 1.35±0.01s          | 0.99    | load.LoadAndRealise.time_load((2, 2, 1000), False, 'FF')                                               |
|          | 20.5±0.07ms          | 20.6±0.3ms          | 1.01    | load.LoadAndRealise.time_load((2, 2, 1000), False, 'NetCDF')                                           |
|          | 1.49±0s              | 1.49±0.01s          | 1.00    | load.LoadAndRealise.time_load((2, 2, 1000), False, 'PP')                                               |
|          | 1.34±0.01s           | 1.36±0.02s          | 1.01    | load.LoadAndRealise.time_load((2, 2, 1000), True, 'FF')                                                |
|          | 20.5±0.3ms           | 20.5±0.4ms          | 1.00    | load.LoadAndRealise.time_load((2, 2, 1000), True, 'NetCDF')                                            |
|          | 1.51±0.01s           | 1.51±0.01s          | 0.99    | load.LoadAndRealise.time_load((2, 2, 1000), True, 'PP')                                                |
|          | 3.99±0.05ms          | 3.91±0.02ms         | 0.98    | load.LoadAndRealise.time_load((50, 50, 2), False, 'FF')                                                |
|          | 19.5±0.1ms           | 19.7±0.2ms          | 1.01    | load.LoadAndRealise.time_load((50, 50, 2), False, 'NetCDF')                                            |
|          | 4.23±0.05ms          | 4.19±0.03ms         | 0.99    | load.LoadAndRealise.time_load((50, 50, 2), False, 'PP')                                                |
|          | 3.91±0.02ms          | 3.90±0.05ms         | 1.00    | load.LoadAndRealise.time_load((50, 50, 2), True, 'FF')                                                 |
|          | 19.8±0.3ms           | 19.7±0.2ms          | 0.99    | load.LoadAndRealise.time_load((50, 50, 2), True, 'NetCDF')                                             |
|          | 4.18±0.01ms          | 4.17±0.02ms         | 1.00    | load.LoadAndRealise.time_load((50, 50, 2), True, 'PP')                                                 |
|          | 33.1±3ms             | 32.4±3ms            | 0.98    | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'FF')                                          |
|          | 19.4±0.7ms           | 19.0±0.5ms          | 0.98    | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'NetCDF')                                      |
|          | 12.9±1ms             | 13.1±3ms            | 1.02    | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'PP')                                          |
|          | 26.3±2ms             | 25.4±1ms            | 0.97    | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'FF')                                           |
|          | 70.6±2ms             | 69.9±2ms            | 0.99    | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'NetCDF')                                       |
|          | 25.7±2ms             | 25.4±1ms            | 0.99    | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'PP')                                           |
|          | 439±3ms              | 437±4ms             | 1.00    | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'FF')                                            |
|          | 2.75±0.08ms          | 2.81±0.09ms         | 1.02    | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'NetCDF')                                        |
|          | 445±6ms              | 439±2ms             | 0.99    | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'PP')                                            |
|          | 442±4ms              | 441±4ms             | 1.00    | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'FF')                                             |
|          | 2.83±0.1ms           | 2.78±0.07ms         | 0.98    | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'NetCDF')                                         |
|          | 448±6ms              | 446±2ms             | 0.99    | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'PP')                                             |
|          | 1.55±0.07ms          | 1.54±0.08ms         | 0.99    | load.LoadAndRealise.time_realise((50, 50, 2), False, 'FF')                                             |
|          | 2.79±0.07ms          | 2.74±0.07ms         | 0.98    | load.LoadAndRealise.time_realise((50, 50, 2), False, 'NetCDF')                                         |
|          | 1.54±0.07ms          | 1.62±0.09ms         | 1.05    | load.LoadAndRealise.time_realise((50, 50, 2), False, 'PP')                                             |
|          | 1.56±0.09ms          | 1.53±0.1ms          | 0.98    | load.LoadAndRealise.time_realise((50, 50, 2), True, 'FF')                                              |
|          | 2.95±0.1ms           | 2.92±0.06ms         | 0.99    | load.LoadAndRealise.time_realise((50, 50, 2), True, 'NetCDF')                                          |
|          | 1.51±0.05ms          | 1.57±0.1ms          | 1.04    | load.LoadAndRealise.time_realise((50, 50, 2), True, 'PP')                                              |
|          | 355±3ms              | 358±5ms             | 1.01    | load.ManyVars.time_many_var_load                                                                       |
|          | 8.25±0.08ms          | 8.17±0.07ms         | 0.99    | load.STASHConstraint.time_stash_constraint((1280, 960, 5), 'FF')                                       |
|          | 8.98±0.03ms          | 9.11±0.2ms          | 1.01    | load.STASHConstraint.time_stash_constraint((1280, 960, 5), 'PP')                                       |
|          | 1.36±0.01s           | 1.34±0.02s          | 0.98    | load.STASHConstraint.time_stash_constraint((2, 2, 1000), 'FF')                                         |
|          | 1.54±0.02s           | 1.52±0.01s          | 0.99    | load.STASHConstraint.time_stash_constraint((2, 2, 1000), 'PP')                                         |
|          | 3.96±0.02ms          | 3.93±0.03ms         | 0.99    | load.STASHConstraint.time_stash_constraint((2, 2, 2), 'FF')                                            |
|          | 4.23±0.03ms          | 4.25±0.04ms         | 1.00    | load.STASHConstraint.time_stash_constraint((2, 2, 2), 'PP')                                            |
|          | 8.08±0.05ms          | 8.06±0.1ms          | 1.00    | load.StructuredFF.time_structured_load((1280, 960, 5), False)                                          |
|          | 4.78±0.09ms          | 4.70±0.02ms         | 0.98    | load.StructuredFF.time_structured_load((1280, 960, 5), True)                                           |
|          | 1.34±0.01s           | 1.32±0.01s          | 0.99    | load.StructuredFF.time_structured_load((2, 2, 1000), False)                                            |
|          | 365±2ms              | 363±2ms             | 1.00    | load.StructuredFF.time_structured_load((2, 2, 1000), True)                                             |
|          | 3.91±0.03ms          | 3.88±0.05ms         | 0.99    | load.StructuredFF.time_structured_load((2, 2, 2), False)                                               |
|          | 3.56±0.02ms          | 3.50±0.03ms         | 0.98    | load.StructuredFF.time_structured_load((2, 2, 2), True)                                                |
|          | 147±2ms              | 143±1ms             | 0.97    | load.TimeConstraint.time_time_constraint(20, 'FF')                                                     |
|          | 22.9±0.1ms           | 23.0±0.1ms          | 1.00    | load.TimeConstraint.time_time_constraint(20, 'NetCDF')                                                 |
|          | 159±1ms              | 159±1ms             | 1.00    | load.TimeConstraint.time_time_constraint(20, 'PP')                                                     |
|          | 28.6±0.3ms           | 28.6±0.3ms          | 1.00    | load.TimeConstraint.time_time_constraint(3, 'FF')                                                      |
|          | 22.6±0.09ms          | 22.6±0.3ms          | 1.00    | load.TimeConstraint.time_time_constraint(3, 'NetCDF')                                                  |
|          | 31.1±0.3ms           | 30.9±0.3ms          | 0.99    | load.TimeConstraint.time_time_constraint(3, 'PP')                                                      |
|          | 17.5±0.3ms           | 17.2±0.3ms          | 0.98    | load.ugrid.BasicLoading.time_load_file(1)                                                              |
|          | 41.2±0.4ms           | 41.0±0.3ms          | 1.00    | load.ugrid.BasicLoading.time_load_file(200000)                                                         |
|          | 13.9±0.3ms           | 14.1±0.1ms          | 1.01    | load.ugrid.BasicLoading.time_load_mesh(1)                                                              |
|          | 21.6±0.4ms           | 21.6±0.3ms          | 1.00    | load.ugrid.BasicLoading.time_load_mesh(200000)                                                         |
|          | 17.2±0.2ms           | 17.3±0.3ms          | 1.00    | load.ugrid.BasicLoadingTime.time_load_file(1)                                                          |
|          | 20.1±0.4ms           | 19.8±0.4ms          | 0.99    | load.ugrid.BasicLoadingTime.time_load_file(200000)                                                     |
|          | 14.1±0.3ms           | 13.9±0.2ms          | 0.99    | load.ugrid.BasicLoadingTime.time_load_mesh(1)                                                          |
|          | 16.5±0.2ms           | 16.6±0.4ms          | 1.00    | load.ugrid.BasicLoadingTime.time_load_mesh(200000)                                                     |
|          | 18.2±0.3ms           | 18.6±0.2ms          | 1.02    | load.ugrid.Callback.time_load_file_callback(1)                                                         |
|          | 50.2±0.5ms           | 49.6±0.5ms          | 0.99    | load.ugrid.Callback.time_load_file_callback(200000)                                                    |
|          | 18.3±0.2ms           | 18.4±0.4ms          | 1.01    | load.ugrid.CallbackTime.time_load_file_callback(1)                                                     |
|          | 21.7±0.4ms           | 21.7±0.8ms          | 1.00    | load.ugrid.CallbackTime.time_load_file_callback(200000)                                                |
|          | 2.68±0.07ms          | 2.69±0.06ms         | 1.00    | load.ugrid.DataRealisation.time_realise_data(10000)                                                    |
|          | 3.89±0.9ms           | 5.49±1ms            | ~1.41   | load.ugrid.DataRealisation.time_realise_data(200000)                                                   |
|          | 37.7±1ms             | 37.7±1ms            | 1.00    | load.ugrid.DataRealisationTime.time_realise_data(10000)                                                |
|          | 794±7ms              | 797±7ms             | 1.00    | load.ugrid.DataRealisationTime.time_realise_data(200000)                                               |
|          | 132±0.8ms            | 118±1ms             | 0.90    | merge_concat.Concatenate.time_concatenate                                                              |
|          | 24.0                 | 24.1                | 1.00    | merge_concat.Concatenate.track_mem_merge                                                               |
|          | 47.6±0.3ms           | 47.0±0.4ms          | 0.99    | merge_concat.Merge.time_merge                                                                          |
|          | 10.9                 | 10.9                | 1.00    | merge_concat.Merge.track_mem_merge                                                                     |
|          | 6.55±0.02ms          | 6.57±0.06ms         | 1.00    | plot.AuxSort.time_aux_sort                                                                             |
|          | 76.5±3ms             | 79.4±3ms            | 1.04    | regridding.CurvilinearRegridding.time_regrid_pic                                                       |
|          | 144.8                | 144.8               | 1.00    | regridding.CurvilinearRegridding.track_mem_regrid_pic                                                  |
|          | 98.3±0.6ms           | 97.4±0.6ms          | 0.99    | regridding.HorizontalChunkedRegridding.time_regrid_area_w                                              |
|          | 48.2±2ms             | 49.0±2ms            | 1.02    | regridding.HorizontalChunkedRegridding.time_regrid_area_w_new_grid                                     |
|          | 111.6                | 111.5               | 1.00    | regridding.HorizontalChunkedRegridding.track_mem_regrid_area_w                                         |
|          | 150.6                | 150.6               | 1.00    | regridding.HorizontalChunkedRegridding.track_mem_regrid_area_w_new_grid                                |
|          | 4.06±0.02ms          | 4.12±0.04ms         | 1.01    | save.NetcdfSave.time_netcdf_save_cube(50, False)                                                       |
|          | 71.4±0.6ms           | 71.2±0.9ms          | 1.00    | save.NetcdfSave.time_netcdf_save_cube(50, True)                                                        |
|          | 52.2±0.6ms           | 52.0±0.8ms          | 1.00    | save.NetcdfSave.time_netcdf_save_cube(600, False)                                                      |
|          | 560±3ms              | 561±5ms             | 1.00    | save.NetcdfSave.time_netcdf_save_cube(600, True)                                                       |
|          | 90.9±2ns             | 90.8±0.6ns          | 1.00    | save.NetcdfSave.time_netcdf_save_mesh(50, False)                                                       |
|          | 55.1±0.5ms           | 54.9±0.6ms          | 1.00    | save.NetcdfSave.time_netcdf_save_mesh(50, True)                                                        |
|          | 90.2±0.5ns           | 90.1±0.8ns          | 1.00    | save.NetcdfSave.time_netcdf_save_mesh(600, False)                                                      |
|          | 493±4ms              | 498±5ms             | 1.01    | save.NetcdfSave.time_netcdf_save_mesh(600, True)                                                       |
|          | 0.3                  | 0.3                 | 1.00    | save.NetcdfSave.track_addedmem_netcdf_save(50, False)                                                  |
|          | 1.8                  | 1.7                 | 0.94    | save.NetcdfSave.track_addedmem_netcdf_save(50, True)                                                   |
|          | 0.3                  | 0.3                 | 1.00    | save.NetcdfSave.track_addedmem_netcdf_save(600, False)                                                 |
|          | 231.1                | 247.6               | 1.07    | save.NetcdfSave.track_addedmem_netcdf_save(600, True)                                                  |
|          | 43.0±0.9ms           | 43.6±1ms            | 1.01    | stats.PearsonR.time_lazy                                                                               |
|          | 18.9±0.1ms           | 18.9±0.3ms          | 1.00    | stats.PearsonR.time_real                                                                               |
|          | 19.5                 | 19.5                | 1.00    | stats.PearsonR.track_lazy                                                                              |
|          | 17.8                 | 17.8                | 1.00    | stats.PearsonR.track_real                                                                              |
|          | 23.8±0.7ms           | 23.6±0.7ms          | 0.99    | trajectory.TrajectoryInterpolation.time_trajectory_linear                                              |
|          | 60.0±0.5ms           | 59.7±0.7ms          | 0.99    | trajectory.TrajectoryInterpolation.time_trajectory_nearest                                             |
|          | 32.2                 | 32.2                | 1.00    | trajectory.TrajectoryInterpolation.track_trajectory_linear                                             |
|          | 21.6                 | 21.6                | 1.00    | trajectory.TrajectoryInterpolation.track_trajectory_nearest                                            |

Generated by GHA run 9773117665

@bouweandela
Copy link
Member Author

bouweandela commented Jul 3, 2024 •
edited
Loading

Not enough to reach the threshold of a 'Performance shift', but this does make concatenate 10% faster:

Change Before [d0801aa] After [8635ff8] Ratio Benchmark (Parameter)
132±0.8ms 118±1ms 0.90 merge_concat.Concatenate.time_concatenate

@bouweandela bouweandela marked this pull request as ready for review July 3, 2024 07:48
@trexfeathers trexfeathers self-assigned this Jul 3, 2024
@pp-mo pp-mo enabled auto-merge (squash) July 9, 2024 16:58
@pp-mo pp-mo merged commit 409f92c into SciTools:main Jul 9, 2024
20 checks passed
@bouweandela bouweandela deleted the faster-concatenate-aux-factory branch July 9, 2024 17:17
tkknight added a commit to tkknight/iris that referenced this pull request Jul 18, 2024
@tkknight
Merge remote-tracking branch 'upstream/main' into autoapi
d6df9a2 
* upstream/main:
  Quieter datum warning (SciTools#6050)
  Allow MeshCoord to have a coord-system (SciTools#6016)
  Bump scitools/workflows from 2024.07.1 to 2024.07.2 (SciTools#6053)
  Faster concatenation of cubes with `AuxCoordFactory`s (SciTools#6038)
  Shorten cube iterator tests (SciTools#6041)
  Bump scitools/workflows from 2024.07.0 to 2024.07.1 (SciTools#6045)
  Bump scitools/workflows from 2024.06.5 to 2024.07.0 (SciTools#6034)
  Update test_Saver__ugrid.py (SciTools#6017)
  NEP29 and NumPy v2 pins (SciTools#6039)
  Adapt setup.py for pypa/setuptools@2db55275f. (SciTools#6036)
  Replace DelegatedConda with Delegated (SciTools#5963)
  Enable type hint checking (SciTools#5956)
  Bump scitools/workflows from 2024.06.4 to 2024.06.5 (SciTools#6026)
  Do not realize cell measures and ancillary variables in concatenate (SciTools#6010)
  [pre-commit.ci] pre-commit autoupdate (SciTools#6022)
  Bump scitools/workflows from 2024.06.3 to 2024.06.4 (SciTools#6018)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pp-mo pp-mo pp-mo approved these changes

@trexfeathers trexfeathers Awaiting requested review from trexfeathers

Assignees

@trexfeathers trexfeathers

Labels
benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bouweandela @pp-mo @trexfeathers