Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable type hint checking #5956

Merged
merged 12 commits into from
Jun 26, 2024
Merged

Conversation

bouweandela
Copy link
Member

🚀 Pull Request

Description

Enable mypy checks and fix issues with current type hints.


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 98.52941% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.77%. Comparing base (1bea71c) to head (74d32b9).

Files Patch % Lines
lib/iris/analysis/maths.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5956      +/-   ##
==========================================
+ Coverage   89.76%   89.77%   +0.01%     
==========================================
  Files          90       90              
  Lines       22969    22984      +15     
  Branches     5029     5031       +2     
==========================================
+ Hits        20618    20634      +16     
+ Misses       1620     1619       -1     
  Partials      731      731              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bouweandela bouweandela marked this pull request as ready for review May 16, 2024 14:45
@stephenworsley stephenworsley self-requested a review May 23, 2024 10:07
Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Massive ❤ for tackling this @bouweandela.

I have some comments for you, and I don't know if @stephenworsley might be half-way through a review?

pyproject.toml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Show resolved Hide resolved
benchmarks/asv_delegated_conda.py Outdated Show resolved Hide resolved
benchmarks/benchmarks/cube.py Show resolved Hide resolved
benchmarks/bm_runner.py Outdated Show resolved Hide resolved
lib/iris/analysis/__init__.py Show resolved Hide resolved
lib/iris/analysis/maths.py Outdated Show resolved Hide resolved
lib/iris/coords.py Outdated Show resolved Hide resolved
lib/iris/experimental/ugrid/cf.py Show resolved Hide resolved
lib/iris/cube.py Show resolved Hide resolved
@trexfeathers trexfeathers self-assigned this Jun 26, 2024
@trexfeathers trexfeathers merged commit 7d6a3f6 into SciTools:main Jun 26, 2024
21 checks passed
@bouweandela bouweandela deleted the enable-type-checking branch June 26, 2024 12:07
@trexfeathers trexfeathers mentioned this pull request Jun 26, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants