Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for ruff rule D400 #5647

Merged
merged 8 commits into from
Dec 18, 2023
Merged

fix for ruff rule D400 #5647

merged 8 commits into from
Dec 18, 2023

Conversation

tkknight
Copy link
Contributor

@tkknight tkknight commented Dec 17, 2023 •
edited
Loading

🚀 Pull Request

Description

PR solely for fixing D400: First line should end with a period

Continues work of #5625.

Consult Iris pull request check list

@tkknight tkknight changed the title fix for ruff rule D400. fix for ruff rule D400 Dec 17, 2023
@tkknight tkknight marked this pull request as draft December 17, 2023 15:45
@tkknight tkknight mentioned this pull request Dec 17, 2023
Open
13 tasks
@codecov Codecov
Copy link

codecov bot commented Dec 17, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (67be801) 89.69% compared to head (cbb0856) 89.69%.

❗ Current head cbb0856 differs from pull request most recent head 92e449d. Consider uploading reports for the commit 92e449d to get more accurate results

Files Patch % Lines
lib/iris/experimental/animate.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5647   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files          90       90           
  Lines       22807    22807           
  Branches     5441     5441           
=======================================
  Hits        20456    20456           
  Misses       1618     1618           
  Partials      733      733

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tkknight
noqa for the gallery.
72b40a5
@tkknight
Merge remote-tracking branch 'upstream/main' into ruff2
cbb0856 
* upstream/main:
  ruff NPY rule compliance (SciTools#5653)
  ruff ICN rule compliance (SciTools#5652)
  ruff EXE rule compliance (SciTools#5651)
  ruff com rule compliance (SciTools#5650)
  Remove compliant ignored ruff rules (SciTools#5649)
  fix for ruff rule D301 (SciTools#5646)
  Updated environment lockfiles (SciTools#5645)
  Bump scitools/workflows from 2023.10.0 to 2023.12.1 (SciTools#5648)
@tkknight
merge fix
a79c450
@bjlittle bjlittle self-requested a review December 18, 2023 15:11
@bjlittle bjlittle self-assigned this Dec 18, 2023
@tkknight
Copy link
Contributor Author

I have added some # noqa: D400 to the gallery_code python docstrings. This is to ignore the D400 rule First line should end with a period. As the docstring for the gallery is used for the .rst it looks better to have the page title without the period.

@tkknight tkknight marked this pull request as ready for review December 18, 2023 15:40
@bjlittle bjlittle merged commit 332a779 into SciTools:main Dec 18, 2023
16 checks passed
@tkknight tkknight deleted the ruff2 branch January 9, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjlittle bjlittle bjlittle approved these changes

Assignees

@bjlittle bjlittle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tkknight @bjlittle